Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds custom sms support #50

Merged
merged 4 commits into from
Nov 22, 2023
Merged

chore: adds custom sms support #50

merged 4 commits into from
Nov 22, 2023

Conversation

nitish-sudo
Copy link
Contributor

@nitish-sudo nitish-sudo commented Nov 22, 2023

PR summary

changes include api changes of

  • Collect failed events
  • Integration create api
  • Custom sms
  • enabled Countries get api
  • updatetemplate is replace to ReplaceTemplate (breaking change)
  • vulnerability fix

Fixes:
https://github.ibm.com/Notification-Hub/planning/issues/10707
https://github.ibm.com/Notification-Hub/planning/issues/10954
https://github.ibm.com/Notification-Hub/planning/issues/11152

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Go Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

SDK was not having below mentioned API changes

  • Collect failed events
  • Integration create api
  • Custom sms
  • enabled Countries get api
  • updatetemplate is replace to ReplaceTemplate

What is the new behavior?

Provided support for below mentioned API

  • Collect failed events
  • Integration create api
  • Custom sms
  • enabled Countries get api
  • updatetemplate is replace to ReplaceTemplate

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: nitish <nitish.kulkarni3@ibm.com>
Signed-off-by: nitish <nitish.kulkarni3@ibm.com>
ankit6193
ankit6193 previously approved these changes Nov 22, 2023
Signed-off-by: nitish <nitish.kulkarni3@ibm.com>
Signed-off-by: nitish <nitish.kulkarni3@ibm.com>
@nitish-sudo nitish-sudo merged commit e4902e7 into main Nov 22, 2023
@nitish-sudo nitish-sudo deleted the sms branch November 22, 2023 18:03
nitish-sudo pushed a commit that referenced this pull request Nov 22, 2023
# [0.4.0](v0.3.0...v0.4.0) (2023-11-22)

### Features

* adds custom sms support ([#50](#50)) ([e4902e7](e4902e7))
@nitish-sudo
Copy link
Contributor Author

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants