Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibm_sm resources should have use references to ibm_resource_instance.sm_instance.guid and ibm_sm_secret_group.sm_secret_group.secret_group_id #4498

Closed
4 tasks
powellquiring opened this issue Apr 12, 2023 · 0 comments · Fixed by #4547
Assignees
Labels
documentation service/Secrets Manager Issues related to Secrets Manager

Comments

@powellquiring
Copy link

powellquiring commented Apr 12, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

New or Affected Resource(s) or Datasource(s)

  • ibm_sm_arbitrary_secret
  • ibm_sm_en_registration
  • ibm_sm_ALL

Description

https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/sm_arbitrary_secret
as an example:

resource "ibm_sm_arbitrary_secret" "sm_arbitrary_secret" {
  instance_id   = "6ebc4224-e983-496a-8a54-f40a0bfa9175"
  region        = "us-south"
  custom_metadata = {"key":"value"}
  secret_group_id = "default"
...
}
  • The secret_group_id should be specified as ibm_sm_secret_group.sm_secret_group.secret_group_id
  • The instance_id should be specified as ibm_resource_instance.sm_instance.guid and perhaps include the resource instance. Why is _guid being used instead of _id?
  • in the description the instance_guid field of the ibm_resource_instance should be mentioned. This is going to be a common first problem for users
    image
  • similar for the secret_group_ip

See key protect as an example:

https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/kms_instance_policies

image

References

@github-actions github-actions bot added the service/Secrets Manager Issues related to Secrets Manager label Apr 12, 2023
@powellquiring powellquiring changed the title ibm_sm resources should have use references to ibm_resource_instance instead of instance_id strings ibm_sm resources should have use references to ibm_resource_instance.sm_instance.guid and ibm_sm_secret_group.sm_secret_group.secret_group_id Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation service/Secrets Manager Issues related to Secrets Manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants