mrboom: improve test reliability #47004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor style concerns, but otherwise 👍 |
30 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the likelihood of a hang. It was consistently doing this on the High Sierra nodes so let's test that out.
The use of
expectoverreadmeans it exits earlier when it finds what it needs - it previously may have waited until the application terminated. There's also a timeout value associated.Now that we can get past
readwithout hanging for long, I've added timeout functionality to theProcess.waitas that that point we've got what we are looking for and don't care about much else. Give it a short 10 seconds and if it can't terminate itself, we'll force it.I also muted the audio for the test.