Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer :script should make its target executable in advance #13607

Closed
vitorgalvao opened this issue Sep 5, 2015 · 1 comment · Fixed by #16021
Closed

installer :script should make its target executable in advance #13607

vitorgalvao opened this issue Sep 5, 2015 · 1 comment · Fixed by #16021

Comments

@vitorgalvao
Copy link
Contributor

Just came across this while working on anaconda. The installer :script target wouldn’t run due to it not having permission to execute. set_permissions doesn’t work to fix this because the soonest it’s available is postflight, and this needed to be preflight. The old way had to be used.

Either way, it should be the responsibility of installer :script to make sure its target can be run.

@vitorgalvao vitorgalvao added discussion bug Issue describing a reproducible bug. core Issue with Homebrew itself rather than with a specific cask. and removed discussion labels Sep 5, 2015
@jawshooah
Copy link
Contributor

While I agree with making installer scripts executable by default, I think the set_permissions and set_ownership methods should be available in the preflight block regardless. PR incoming.

@miccal miccal removed bug Issue describing a reproducible bug. core Issue with Homebrew itself rather than with a specific cask. labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants