Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do Givens rotations and reflections operate on the tangent space? #17

Open
lihuiliullh opened this issue Dec 19, 2024 · 0 comments
Open

Do Givens rotations and reflections operate on the tangent space? #17

lihuiliullh opened this issue Dec 19, 2024 · 0 comments

Comments

@lihuiliullh
Copy link

When I read the paper, I thought the Givens rotations and reflections operate on poincare space, but after reading the code
it seems like Givens rotations and reflections operate on tangent space. Do I miss something here?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lihuiliullh