[core] Protect RCV buffer access from socket stats

maxsharabayko · maxsharabayko · commit a60d98a24375 · 2022-03-08T16:29:33.000+01:00
diff --git a/srtcore/core.cpp b/srtcore/core.cpp
@@ -7449,7 +7449,8 @@ void srt::CUDT::bstats(CBytePerfMon *perf, bool clear, bool instantaneous)
 
         if (m_pRcvBuffer)
         {
-            perf->byteAvailRcvBuf = getAvailRcvBufferSizeLock() * m_config.iMSS;
+            ScopedLock lck(m_RcvBufferLock);
+            perf->byteAvailRcvBuf = getAvailRcvBufferSizeNoLock() * m_config.iMSS;
             if (instantaneous) // no need for historical API for Rcv side
             {
                 perf->pktRcvBuf = m_pRcvBuffer->getRcvDataSize(perf->byteRcvBuf, perf->msRcvBuf);

Original file line number	Diff line number	Diff line change
`@@ -7449,7 +7449,8 @@ void srt::CUDT::bstats(CBytePerfMon *perf, bool clear, bool instantaneous)`
`7449`	`7449`
`7450`	`7450`	`if (m_pRcvBuffer)`
`7451`	`7451`	`{`
`7452`		`- perf->byteAvailRcvBuf = getAvailRcvBufferSizeLock() * m_config.iMSS;`
	`7452`	`+ ScopedLock lck(m_RcvBufferLock);`
	`7453`	`+ perf->byteAvailRcvBuf = getAvailRcvBufferSizeNoLock() * m_config.iMSS;`
`7453`	`7454`	`if (instantaneous) // no need for historical API for Rcv side`
`7454`	`7455`	`{`
`7455`	`7456`	`perf->pktRcvBuf = m_pRcvBuffer->getRcvDataSize(perf->byteRcvBuf, perf->msRcvBuf);`