[Issue #2625] set max-ages for app pages #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
previously approved these changes
Dec 4, 2024
acouch
force-pushed
the
acouch/issue-2625-frontend-headers
branch
from
1fa8e9d to
6c3ddd0
Compare
|
Updated since review to include correct setting for |
acouch
commented
Dec 5, 2024
| @@ -6,7 +6,7 @@ | |||
| "node": ">=20.0.0" | |||
| }, | |||
| "scripts": { | |||
| "all-checks": "npm run test && npm run lint && npm run ts:check && npm run build", | |||
| "all-checks": "npm run lint && npm run ts:check && npm run test && npm run build", | |||
There was a problem hiding this comment.
@doug-s-nava I moved npm run test last since the test takes longest and it stops if the test fails (which has happened a couple of times).
doug-s-nava
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2625
Time to review: 5 mins
Changes proposed
Explicitly set the headers for different parts of the app so they are cached by clients and the CDN appropriately.