Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for localization with vscode-loc installed. #755

Open
hwhsu1231 opened this issue Apr 26, 2023 · 6 comments
Open

[feature] Add support for localization with vscode-loc installed. #755

hwhsu1231 opened this issue Apr 26, 2023 · 6 comments

Comments

@hwhsu1231
Copy link

Feature Request

There is a VSCode Localization Extension provided by Microsoft, vscode-loc.

According to: microsoft/vscode-loc#894 (comment)

It seems that we should ask particular extensions to support its localization.

Can this extension support the localization with the vscode-loc installed?

@Gruntfuggly
Copy link
Owner

The extension already supports localization as long as somebody provides the translations. There is already a zh-cn translation file kindly provided by a user, but I don't have the time or language skills to do any myself.

@hwhsu1231
Copy link
Author

hwhsu1231 commented Apr 27, 2023

@Gruntfuggly

So suppose that I want to add a "Traditional Chinese (Taiwan)" localization. All I need to do is:

  1. Copy and paste a package.nls.json and rename to package.nls.zh-tw.json.
  2. Add some translations in package.nls.zh-tw.json.
  3. Create a PR to submit the change.

Right?

@Gruntfuggly
Copy link
Owner

Pretty much - if you want to give it a go, I can package up a test version of the extension so you can try it out.

@hwhsu1231
Copy link
Author

@Gruntfuggly

In fact, I've already started to working on the package.nls.zh-tw.json in my forked repo:

After completing the translations, all I need to do is to submit a PR to the upstream, right?

@hwhsu1231
Copy link
Author

hwhsu1231 commented Apr 29, 2023

@Gruntfuggly

I noticed that some translation entries in zh-cn are missing when I was translating zh-tw. I think it might be because package.nls.zh-cn.json wasn't updated in sync when updating package.nls.json, right? If that's the case, could you please try to keep all the package.nls.XXX.json files updated in sync in the future?

@hwhsu1231
Copy link
Author

@Gruntfuggly - I've submitted a PR to add zh-tw translations (#756). Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants