Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework allocation to be "by property" #83

Closed
bkuczenski opened this issue May 1, 2019 · 2 comments
Closed

Rework allocation to be "by property" #83

bkuczenski opened this issue May 1, 2019 · 2 comments

Comments

@bkuczenski
Copy link

bkuczenski commented May 1, 2019

There is no meaningful functional difference between physical and economic allocation-- all it does is choose one flow property or another to determine allocation factors. But at present it is left to the app to figure out which flow property to use.

For instance, the user manual says: " In order for allocation to work, the main product and the co-products of the multioutput process need to have the same flow property." In other words, the app is inspecting the process and deciding what property to use for allocation. Similarly, for economic allocation the flow property being used is unclear, but is apparently required to be "Market value, bulk prices," leading to problems like this one. and leading to annoyances if using a process whose flows are not characterized by that quantity.

The proposed solution would be to replace "physical | economic | causal" allocation to be "allocation by property | causal", and if "allocation by property" is chosen, then the UI offers a drop-down for all eligible properties, i.e. all properties that are characterized for all reference flows, being physical, economic, social, whatever. Then the user picks the quantity to use. This also has the advantage of providing immediate feedback to the user about how the allocation calculation is being performed.

By the way, I would also recommend a more tolerant allocation algorithm that does not require all outputs to be characterized by the same flow property, but simply assigns allocation factors of zero to all flows not characterized by the designated property. In this case, "all eligible properties" would be any property that appears on any reference flow, not any property that appears on all reference flows.

@msrocka
Copy link
Member

msrocka commented May 2, 2019

I think the problem with the economic allocation factors is related to the fact that the products need to have a common flow property which is tagged as economic (which is the case for Market value, bulk prices but not limited to that)…

But I agree (and +1): selecting the property that should be used for the calculation of the factors (with a more tolerant algorithm) would be much better.

I would still keep the categories economic, physical, and causal because this is then used in the calculation setup of a product system to decide which factors should be selected in the calculation for the respective processes (where each process could have different properties from which these allocation factors are derived).

Also note that the factors can be set/edited manually and that there is also this issue #31.

@msrocka
Copy link
Member

msrocka commented Jul 29, 2022

In openLCA 2 (beta1), this is better now: you can select the properties that should be used for calculating the allocation factors:

image

Also, you can always just enter the factors manually without using that dialog. The factors are shown in red when they do not sum up to 1.

@msrocka msrocka closed this as completed Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants