Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetPath test fails in Windows #105

Closed
teohaik opened this issue Apr 23, 2023 · 3 comments
Closed

GetPath test fails in Windows #105

teohaik opened this issue Apr 23, 2023 · 3 comments

Comments

@teohaik
Copy link
Contributor

teohaik commented Apr 23, 2023

\sui4j\src\test\resources\config\sui.keystore

assertTrue(StringUtils.endsWith(fileBasedKeyStore.getPath(), "config/sui.keystore"));

This assertion is not working in Windows due to different path separator.

Will create a fix and push it in my forked repo. Don't have access to push here.
@teohaik
Copy link
Contributor Author

teohaik commented Apr 23, 2023

Can you please add me as collaborator so that i can push my branch with fix?

@teohaik teohaik mentioned this issue Apr 24, 2023
Merged
@GrapeBaBa
Copy link
Owner

Can you please add me as collaborator so that i can push my branch with fix?

@teohaik invited, very glad that you are interested.

@GrapeBaBa
Copy link
Owner

already fixed in #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teohaik @GrapeBaBa