Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't provide "default" implementation in RegistryEndpointProvider interface #2117

Closed
chanseokoh opened this issue Nov 1, 2019 · 0 comments · Fixed by #2118
Closed

Don't provide "default" implementation in RegistryEndpointProvider interface #2117

chanseokoh opened this issue Nov 1, 2019 · 0 comments · Fixed by #2118
Labels

Comments

@chanseokoh
Copy link
Member

It's generally considered not a good practice.

  default T handleHttpResponseException(ResponseException responseException)
      throws ResponseException, RegistryErrorException {
    throw responseException;
  }

Each RegistryEndpointProvider can just throw the given exception if not interested in it. The Javadoc of the interface can make this clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant