Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make host configurable #19

Closed
kanekv opened this issue Feb 12, 2020 · 4 comments · Fixed by #20
Closed

make host configurable #19

kanekv opened this issue Feb 12, 2020 · 4 comments · Fixed by #20
Labels
enhancement New feature or request

Comments

@kanekv
Copy link
Contributor

kanekv commented Feb 12, 2020

On mac every time it reloads there is a firewall alert because it's fixed listen on 0.0.0.0. Can we add --host option to override the interface?
@di di added the enhancement New feature or request label Feb 18, 2020
@di
Copy link
Member

di commented Feb 18, 2020

Yup, sounds like a good idea. Would you like to work on this?

@kanekv
Copy link
Contributor Author

kanekv commented Feb 18, 2020

Sure, I'll submit a PR if you are not against it.

@di
Copy link
Member

di commented Feb 18, 2020

Please do!

@kanekv kanekv mentioned this issue Feb 19, 2020
Merged
@di di closed this as completed in #20 Feb 20, 2020
@di
Copy link
Member

di commented Feb 20, 2020

Released in functions-framework==1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add --host command line argument kanekv/functions-framework-python
2 participants
@di @kanekv