Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad logic introduced while limiting logged warnings in entity.cgi #1453

Closed
jonstout opened this issue Dec 8, 2022 · 0 comments
Closed

Bad logic introduced while limiting logged warnings in entity.cgi #1453

jonstout opened this issue Dec 8, 2022 · 0 comments

Comments

@jonstout
Copy link
Member

jonstout commented Dec 8, 2022

Logic introduced here had the side effect of limiting some interfaces from being returned in entity.cgi?method=get_entities. The removed interfaces are those with ACLs containing no workgroup restrictions (an undef workgroup_id).

This line is incorrect:
https://github.com/GlobalNOC/OESS/blob/master/frontend/webservice/entity.cgi#L477

The correct logic should be:

next if (defined($acl->{'workgroup_id'}) && $acl->{'workgroup_id'} != $workgroup_id);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant