#470: improve method implementation

mmerdes · rtroilo · commit 623ba13bfafe · 2022-11-11T14:55:20.000+01:00
diff --git a/oshdb/src/main/java/org/heigit/ohsome/oshdb/OSHDBTags.java b/oshdb/src/main/java/org/heigit/ohsome/oshdb/OSHDBTags.java
@@ -143,8 +143,8 @@ public boolean hasTag(int key, int value) {
     @Override
     public boolean hasTag(OSHDBTag tag) {
       for (int i = 0; i < tags.length; i += 2) {
-        if (tags[i] == tag.getKey() && tags[i + 1] == tag.getValue()) {
-          return true;
+        if (tags[i] == tag.getKey()) {
+          return tags[i + 1] == tag.getValue();
         }
       }
       return false;

Original file line number	Diff line number	Diff line change
`@@ -143,8 +143,8 @@ public boolean hasTag(int key, int value) {`
`143`	`143`	`@Override`
`144`	`144`	`public boolean hasTag(OSHDBTag tag) {`
`145`	`145`	`for (int i = 0; i < tags.length; i += 2) {`
`146`		`- if (tags[i] == tag.getKey() && tags[i + 1] == tag.getValue()) {`
`147`		`- return true;`
	`146`	`+ if (tags[i] == tag.getKey()) {`
	`147`	`+ return tags[i + 1] == tag.getValue();`
`148`	`148`	`}`
`149`	`149`	`}`
`150`	`150`	`return false;`