From 2800b588baddd702717c200d60562cab7c4a87cf Mon Sep 17 00:00:00 2001 From: kokeshiM0chi Date: Tue, 5 Sep 2023 15:02:31 +0900 Subject: [PATCH 1/7] chore: Added comment about ordering of addresses --- docs/proto/proto-docs.md | 2 +- proto/lbm/wasm/v1/query.proto | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/proto/proto-docs.md b/docs/proto/proto-docs.md index 1ca5b041d3..3cdd8cd501 100644 --- a/docs/proto/proto-docs.md +++ b/docs/proto/proto-docs.md @@ -1508,7 +1508,7 @@ Query/InactiveContract RPC method. | Field | Type | Label | Description | | ----- | ---- | ----- | ----------- | -| `addresses` | [string](#string) | repeated | addresses is the inactive address list | +| `addresses` | [string](#string) | repeated | addresses are the inactive address list of byte arrays ordered in ascending order | | `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response | diff --git a/proto/lbm/wasm/v1/query.proto b/proto/lbm/wasm/v1/query.proto index 7c539e4211..9574c2132a 100644 --- a/proto/lbm/wasm/v1/query.proto +++ b/proto/lbm/wasm/v1/query.proto @@ -34,7 +34,7 @@ message QueryInactiveContractsRequest { // QueryInactiveContractsResponse is the response type for the // Query/InactiveContract RPC method. message QueryInactiveContractsResponse { - // addresses is the inactive address list + // addresses are the inactive address list of byte arrays ordered in ascending order repeated string addresses = 1; // pagination defines the pagination in the response From ea81490254b9da5734e45e9ce9fb535073bfd21e Mon Sep 17 00:00:00 2001 From: kokeshiM0chi Date: Tue, 5 Sep 2023 15:07:54 +0900 Subject: [PATCH 2/7] chore: add this pr to change.log --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 93b45b204d..a5a31f3564 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,6 +48,7 @@ * [\#54](https://github.com/Finschia/wasmd/pull/54) add documentation about errors (codespace and codes) * [\#92](https://github.com/Finschia/wasmd/pull/92) modify links in x/wasmplus README.md * [\#103](https://github.com/Finschia/wasmd/pull/103) add clarifications to the order of list response in query +* [\#107](https://github.com/Finschia/wasmd/pull/107) Added comment about ordering of addresses ## [v0.1.4](https://github.com/Finschia/wasmd/releases/tag/v0.1.4) - 2023.05.22 From 975777a1d714702da322eb90b41a8ade03a0915b Mon Sep 17 00:00:00 2001 From: kokeshiM0chi Date: Tue, 5 Sep 2023 16:51:01 +0900 Subject: [PATCH 3/7] fix: fix singular --- proto/lbm/wasm/v1/query.proto | 2 +- x/wasmplus/types/query.pb.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/proto/lbm/wasm/v1/query.proto b/proto/lbm/wasm/v1/query.proto index 9574c2132a..dd7c681e93 100644 --- a/proto/lbm/wasm/v1/query.proto +++ b/proto/lbm/wasm/v1/query.proto @@ -34,7 +34,7 @@ message QueryInactiveContractsRequest { // QueryInactiveContractsResponse is the response type for the // Query/InactiveContract RPC method. message QueryInactiveContractsResponse { - // addresses are the inactive address list of byte arrays ordered in ascending order + // addresses is the inactive address list of byte arrays ordered in ascending order repeated string addresses = 1; // pagination defines the pagination in the response diff --git a/x/wasmplus/types/query.pb.go b/x/wasmplus/types/query.pb.go index 788a8a6d74..85dc43d17a 100644 --- a/x/wasmplus/types/query.pb.go +++ b/x/wasmplus/types/query.pb.go @@ -82,7 +82,7 @@ var xxx_messageInfo_QueryInactiveContractsRequest proto.InternalMessageInfo // QueryInactiveContractsResponse is the response type for the // Query/InactiveContract RPC method. type QueryInactiveContractsResponse struct { - // addresses is the inactive address list + // addresses is the inactive address list of byte arrays ordered in ascending order Addresses []string `protobuf:"bytes,1,rep,name=addresses,proto3" json:"addresses,omitempty"` // pagination defines the pagination in the response Pagination *query.PageResponse `protobuf:"bytes,2,opt,name=pagination,proto3" json:"pagination,omitempty"` From 8a5b30fa05c0f0aa9a895cd2c36c1da2605a01bd Mon Sep 17 00:00:00 2001 From: kokeshiM0chi Date: Tue, 5 Sep 2023 16:53:50 +0900 Subject: [PATCH 4/7] fix: fix pr title --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a5a31f3564..2bc6149e01 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,7 +48,7 @@ * [\#54](https://github.com/Finschia/wasmd/pull/54) add documentation about errors (codespace and codes) * [\#92](https://github.com/Finschia/wasmd/pull/92) modify links in x/wasmplus README.md * [\#103](https://github.com/Finschia/wasmd/pull/103) add clarifications to the order of list response in query -* [\#107](https://github.com/Finschia/wasmd/pull/107) Added comment about ordering of addresses +* [\#107](https://github.com/Finschia/wasmd/pull/107) Added comment about ordering of addresses in wasmplus ## [v0.1.4](https://github.com/Finschia/wasmd/releases/tag/v0.1.4) - 2023.05.22 From 7fa4ad0d6636693929b5d813705a7881c528c3fd Mon Sep 17 00:00:00 2001 From: kokeshiM0chi Date: Tue, 5 Sep 2023 16:56:58 +0900 Subject: [PATCH 5/7] fix: fix singular --- docs/proto/proto-docs.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/proto/proto-docs.md b/docs/proto/proto-docs.md index 3cdd8cd501..b22aa6b659 100644 --- a/docs/proto/proto-docs.md +++ b/docs/proto/proto-docs.md @@ -1506,10 +1506,10 @@ QueryInactiveContractsResponse is the response type for the Query/InactiveContract RPC method. -| Field | Type | Label | Description | -| ----- | ---- | ----- | ----------- | -| `addresses` | [string](#string) | repeated | addresses are the inactive address list of byte arrays ordered in ascending order | -| `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response | +| Field | Type | Label | Description | +| ----- | ---- | ----- |---------------------------------------------------------------------------------| +| `addresses` | [string](#string) | repeated | addresses is the inactive address list of byte arrays ordered in ascending order | +| `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response | From 113db50ffc97240879c40bc8fe597037ac89e2ce Mon Sep 17 00:00:00 2001 From: kokeshiM0chi Date: Tue, 5 Sep 2023 17:22:41 +0900 Subject: [PATCH 6/7] fix: Correct uppercase letters to lowercase letters --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2bc6149e01..0c93feb1be 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,7 +48,7 @@ * [\#54](https://github.com/Finschia/wasmd/pull/54) add documentation about errors (codespace and codes) * [\#92](https://github.com/Finschia/wasmd/pull/92) modify links in x/wasmplus README.md * [\#103](https://github.com/Finschia/wasmd/pull/103) add clarifications to the order of list response in query -* [\#107](https://github.com/Finschia/wasmd/pull/107) Added comment about ordering of addresses in wasmplus +* [\#107](https://github.com/Finschia/wasmd/pull/107) added comment about ordering of addresses in wasmplus ## [v0.1.4](https://github.com/Finschia/wasmd/releases/tag/v0.1.4) - 2023.05.22 From 74aef720350b8662cc5f1e298df734198151f28e Mon Sep 17 00:00:00 2001 From: kokeshiM0chi Date: Thu, 7 Sep 2023 14:52:42 +0900 Subject: [PATCH 7/7] fix: Correct to specify the type of elements in List of addresses --- CHANGELOG.md | 2 +- docs/proto/proto-docs.md | 2 +- proto/lbm/wasm/v1/query.proto | 2 +- x/wasmplus/types/query.pb.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0c93feb1be..b693b72616 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,7 +48,7 @@ * [\#54](https://github.com/Finschia/wasmd/pull/54) add documentation about errors (codespace and codes) * [\#92](https://github.com/Finschia/wasmd/pull/92) modify links in x/wasmplus README.md * [\#103](https://github.com/Finschia/wasmd/pull/103) add clarifications to the order of list response in query -* [\#107](https://github.com/Finschia/wasmd/pull/107) added comment about ordering of addresses in wasmplus +* [\#107](https://github.com/Finschia/wasmd/pull/107) add comment about ordering of addresses in wasmplus ## [v0.1.4](https://github.com/Finschia/wasmd/releases/tag/v0.1.4) - 2023.05.22 diff --git a/docs/proto/proto-docs.md b/docs/proto/proto-docs.md index b22aa6b659..f8ff17ead2 100644 --- a/docs/proto/proto-docs.md +++ b/docs/proto/proto-docs.md @@ -1508,7 +1508,7 @@ Query/InactiveContract RPC method. | Field | Type | Label | Description | | ----- | ---- | ----- |---------------------------------------------------------------------------------| -| `addresses` | [string](#string) | repeated | addresses is the inactive address list of byte arrays ordered in ascending order | +| `addresses` | [string](#string) | repeated | addresses is the inactive address list of strings, in ascending order of byte format | | `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response | diff --git a/proto/lbm/wasm/v1/query.proto b/proto/lbm/wasm/v1/query.proto index dd7c681e93..5f7eaea8b8 100644 --- a/proto/lbm/wasm/v1/query.proto +++ b/proto/lbm/wasm/v1/query.proto @@ -34,7 +34,7 @@ message QueryInactiveContractsRequest { // QueryInactiveContractsResponse is the response type for the // Query/InactiveContract RPC method. message QueryInactiveContractsResponse { - // addresses is the inactive address list of byte arrays ordered in ascending order + // addresses is the inactive address list of strings, in ascending order of byte format repeated string addresses = 1; // pagination defines the pagination in the response diff --git a/x/wasmplus/types/query.pb.go b/x/wasmplus/types/query.pb.go index 85dc43d17a..c990333a89 100644 --- a/x/wasmplus/types/query.pb.go +++ b/x/wasmplus/types/query.pb.go @@ -82,7 +82,7 @@ var xxx_messageInfo_QueryInactiveContractsRequest proto.InternalMessageInfo // QueryInactiveContractsResponse is the response type for the // Query/InactiveContract RPC method. type QueryInactiveContractsResponse struct { - // addresses is the inactive address list of byte arrays ordered in ascending order + // addresses is the inactive address list of strings, in ascending order of byte format Addresses []string `protobuf:"bytes,1,rep,name=addresses,proto3" json:"addresses,omitempty"` // pagination defines the pagination in the response Pagination *query.PageResponse `protobuf:"bytes,2,opt,name=pagination,proto3" json:"pagination,omitempty"`