Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made kind of BENode public #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Made kind of BENode public #1

wants to merge 2 commits into from

Conversation

cmd410
Copy link

@cmd410 cmd410 commented Feb 5, 2022

Now users can differentiate nodes by kind.
Without this I keep getting an error:

Error: type mismatch: got <BENode>
but expected one of:
proc kind(n: NimNode): NimNodeKind
  first type mismatch at position: 1
  required type for n: NimNode
  but expression 'result' is of type: BENode

cmd410 added 2 commits February 5, 2022 18:54
@cmd410
Make kind public
8402a7a 
kind being private doesn't allow to differentiate nodes by kind outside of the library, so one gets an error:
```Error: type mismatch: got <BENode>
but expected one of:
proc kind(n: NimNode): NimNodeKind
  first type mismatch at position: 1
  required type for n: NimNode```
@cmd410
Bump version
1a78bf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmd410