Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature.export should be renamed to Feature.to_zip #552

Closed
xgui3783 opened this issue Feb 1, 2024 · 2 comments
Closed

Feature.export should be renamed to Feature.to_zip #552

xgui3783 opened this issue Feb 1, 2024 · 2 comments
Assignees
@AhmetNSimsek

Comments

@xgui3783
Copy link
Member

xgui3783 commented Feb 1, 2024

Per meeting notes from https://github.com/FZJ-INM1-BDA/siibra-development/blob/main/meetings/2024/20240125.md?plain=1#L33 ,

Feature.export should be renamed Feature.to_zip to be as explicity as possible.
@xgui3783
Copy link
Member Author

xgui3783 commented Feb 1, 2024

@AhmetNSimsek have you started on this?

If not, I can take this issue.

@xgui3783 xgui3783 changed the title Feature.export should be renamed to to_zip Feature.export should be renamed to Feature.to_zip Feb 1, 2024
@AhmetNSimsek
Copy link
Collaborator

I am working on it already including with get_volume method for parcellation map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AhmetNSimsek AhmetNSimsek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xgui3783 @AhmetNSimsek