chore: add instance check to regex

xgui3783 · xgui3783 · commit c54cee118d48 · 2021-10-13T17:04:42.000+02:00
diff --git a/siibra/core/region.py b/siibra/core/region.py
@@ -44,6 +44,7 @@
     "Both",
 ]
 
+REGEX_TYPE=type(re.compile('test'))
 
 class Region(anytree.NodeMixin, AtlasConcept):
     """
@@ -290,7 +291,7 @@ def splitstr(s):
                     ]
                 )
         # Python 3.6 does not support re.Pattern
-        elif hasattr(re, 'Pattern') and isinstance(regionspec, re.Pattern):
+        elif isinstance(regionspec, REGEX_TYPE):
             # match regular expression
             return any(regionspec.search(s) is not None for s in [self.name, self.key])
         else:

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@`
`44`	`44`	`"Both",`
`45`	`45`	`]`
`46`	`46`
	`47`	`+REGEX_TYPE=type(re.compile('test'))`
`47`	`48`
`48`	`49`	`class Region(anytree.NodeMixin, AtlasConcept):`
`49`	`50`	`"""`
`@@ -290,7 +291,7 @@ def splitstr(s):`
`290`	`291`	`]`
`291`	`292`	`)`
`292`	`293`	`# Python 3.6 does not support re.Pattern`
`293`		`- elif hasattr(re, 'Pattern') and isinstance(regionspec, re.Pattern):`
	`294`	`+ elif isinstance(regionspec, REGEX_TYPE):`
`294`	`295`	`# match regular expression`
`295`	`296`	`return any(regionspec.search(s) is not None for s in [self.name, self.key])`
`296`	`297`	`else:`