Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support comma separated files input #3

Merged
merged 7 commits into from
Dec 20, 2023
Merged

fix: support comma separated files input #3

merged 7 commits into from
Dec 20, 2023
+19 −5

Conversation

p5
Copy link
Contributor

@p5 p5 commented Dec 20, 2023

You are not able to pass in multiple lines to GITHUB_ENV, so this changes the action to support comma-separated list of inputs instead.

Added a clean step to the Containerfile to remove cache as this does not need to be distributed with the image.

Added a new spec file to the test workflow to validate if the changes in this PR work as expected.

p5 added 4 commits December 20, 2023 11:50
@p5
Add test cases for multiple spec files

Verified

This commit was signed with the committer’s verified signature.
p5 Robert Sturla
SSH Key Fingerprint: 6/K5emtkmCwjdOpdqQbZVqi8lsH0Z6xQajU4+bcap6Q
Verified
Learn about vigilant mode
6bb8407
@p5
Cleanup dnf cache after installing

Verified

This commit was signed with the committer’s verified signature.
p5 Robert Sturla
SSH Key Fingerprint: 6/K5emtkmCwjdOpdqQbZVqi8lsH0Z6xQajU4+bcap6Q
Verified
Learn about vigilant mode
ca98dba
@p5
Accept comma-separated list of spec files

Verified

This commit was signed with the committer’s verified signature.
p5 Robert Sturla
SSH Key Fingerprint: 6/K5emtkmCwjdOpdqQbZVqi8lsH0Z6xQajU4+bcap6Q
Verified
Learn about vigilant mode
da880eb
@p5
Update comment (remove Copilot prompt)

Verified

This commit was signed with the committer’s verified signature.
p5 Robert Sturla
SSH Key Fingerprint: 6/K5emtkmCwjdOpdqQbZVqi8lsH0Z6xQajU4+bcap6Q
Verified
Learn about vigilant mode
101be54
EyeCantCU
EyeCantCU approved these changes Dec 20, 2023
View reviewed changes
Copy link
Owner

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks great, really appreciate the pull request!

@p5
Copy link
Contributor Author

p5 commented Dec 20, 2023

Everything here looks great, really appreciate the pull request!

Please note I have not tested anything in this PR. May not be good to merge yet

@EyeCantCU
Copy link
Owner

Everything here looks great, really appreciate the pull request!

Please note I have not tested anything in this PR. May not be good to merge yet

Yup. I had figured as it is a draft. I can add a test real fast to ensure everything is good :)

@EyeCantCU EyeCantCU force-pushed the comma-separated-files branch from 51d5c31 to ca62582 Compare December 20, 2023 15:36
@EyeCantCU
Copy link
Owner

@p5 looks like it works! Any additions you'd like to make to this pull request?

@p5
Copy link
Contributor Author

p5 commented Dec 20, 2023 •
edited
Loading

@p5 looks like it works! Any additions you'd like to make to this pull request?

Thanks for reviewing and testing!
Nothing I can think of. It does everything we need it to, but can always add more later when we find it

I'm on mobile and can't find the button to mark it ready for review, so happy for you to merge when ready.

@EyeCantCU
Copy link
Owner

Terrific! Once again, thank you. Will merge now

@EyeCantCU EyeCantCU marked this pull request as ready for review December 20, 2023 15:45
@EyeCantCU EyeCantCU merged commit ab9ea0e into EyeCantCU:main Dec 20, 2023
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EyeCantCU EyeCantCU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p5 @EyeCantCU