Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA][HybridApp] Fix is-hybrid-app.sh script #57484

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+13 −2
Open

[No QA][HybridApp] Fix is-hybrid-app.sh script #57484

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c3b9ac5
Remove set -e from the script
mateuuszzzzz Feb 26, 2025
42228e5
Merge branch 'main' into fix-is-hybrid-app-script
mateuuszzzzz Feb 27, 2025
3e0c6cf
Add jq check
mateuuszzzzz Feb 27, 2025
706e890
Remove reference to function that is not defined
mateuuszzzzz Feb 27, 2025
300ebde
Handle incorrect package name explicitly
mateuuszzzzz Feb 27, 2025
76eae08
Fix lint issues
mateuuszzzzz Feb 27, 2025
cdca36f
Change error to echo
mateuuszzzzz Feb 27, 2025
b6b2da7
Use Expensify shell utils
mateuuszzzzz Feb 27, 2025
d74f7f3
Fix typo
mateuuszzzzz Feb 27, 2025
d704f7a
Redirect to stderr to make script more verbose in case of error
mateuuszzzzz Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions scripts/is-hybrid-app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
#!/bin/bash
set -e

source scripts/shellUtils.sh

# Check if jq is installed
if ! jq --version > /dev/null 2>&1; then
error 'jq is not installed. Please install jq and try again' >&2
exit 1
fi

if [[ ! -d Mobile-Expensify ]]; then
echo false
exit 0
else
cd Mobile-Expensify
cd Mobile-Expensify || exit 1
fi

# Check if 'package.json' exists
Expand All @@ -17,6 +24,10 @@ if [[ -f package.json ]]; then
if [[ "$package_name" == "mobile-expensify" ]]; then
echo true
exit 0
else
echo "The package name is incorrect. It should be 'mobile-expensify'. Script will assume the standalone NewDot app."
echo false
exit 0
fi
else
echo "package.json not found in Mobile-Expensify"
Expand Down
Loading