From 5f16a76eb225f78c83b6a8ad1cdf750b604e277b Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Mon, 6 Feb 2023 14:15:35 +0000 Subject: [PATCH 1/2] Invert the condition --- src/components/OptionRow.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/OptionRow.js b/src/components/OptionRow.js index bf71013e595d..d5933003dda9 100644 --- a/src/components/OptionRow.js +++ b/src/components/OptionRow.js @@ -95,7 +95,7 @@ class OptionRow extends Component { || this.props.isSelected !== nextProps.isSelected || this.props.showSelectedState !== nextProps.showSelectedState || this.props.showTitleTooltip !== nextProps.showTitleTooltip - || !_.isEqual(this.props.option.icons, nextProps.option.icons) + || _.isEqual(this.props.option.icons, nextProps.option.icons) || this.props.option.text !== nextProps.option.text || this.props.option.alternateText !== nextProps.option.alternateText || this.props.option.descriptiveText !== nextProps.option.descriptiveText From 495f0dff32d4ed5ac49b1e302bf7512ce2694b22 Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Mon, 6 Feb 2023 14:29:51 +0000 Subject: [PATCH 2/2] Add forgotten options to OptionRow re-render logic --- src/components/OptionRow.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/OptionRow.js b/src/components/OptionRow.js index d5933003dda9..59faa18eb45c 100644 --- a/src/components/OptionRow.js +++ b/src/components/OptionRow.js @@ -95,7 +95,8 @@ class OptionRow extends Component { || this.props.isSelected !== nextProps.isSelected || this.props.showSelectedState !== nextProps.showSelectedState || this.props.showTitleTooltip !== nextProps.showTitleTooltip - || _.isEqual(this.props.option.icons, nextProps.option.icons) + || !_.isEqual(this.props.option.icons, nextProps.option.icons) + || this.props.optionIsFocused !== nextProps.optionIsFocused || this.props.option.text !== nextProps.option.text || this.props.option.alternateText !== nextProps.option.alternateText || this.props.option.descriptiveText !== nextProps.option.descriptiveText