Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Money - "Looks like you're offline" message displayed on top of the Send button #9808

Closed
kbecciv opened this issue Jul 8, 2022 · 6 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Jul 8, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with expensifail account
  3. Click on Fub menu and Select Send money
  4. Put amount and select Continue
  5. Turn off the internet connection

Expected Result:

"Looks like you're offline" message displayed under Send button

Actual Result:

"Looks like you're offline" message displayed on top of the Send button

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.82.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (30)

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2022

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Luke9389 Luke9389 added the External Added to denote the issue can be worked on by a contributor label Jul 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2022

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@thesahindia
Copy link
Member

I don't think this is a bug. It is probably intentional and if we move the offline text below the button the position of the button will change.

cc: @Luke9389 @roryabraham

@parasharrajat
Copy link
Member

This should be on hold until we touch offline functionality like other issues.

@kadiealexander
Copy link
Contributor

Holding on publishing this until I get clarification on the above.

@Luke9389
Copy link
Contributor

I think we can actually just close this. We intend to take that message out of the form with submit button entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants