mWeb - Error message displayed when trying to upload document on onfido flow and user is redirected to Company step #6085

isagoico · 2021-10-27T18:42:30Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Navigate to add a bank account modal
Enter some bank account credentials that trigger the Onfido flow
Select drivers license
Take a picture of anything

Expected Result:

Picture should be uploaded and then scanned by onfido

Actual Result:

There's an error just as the image is uploaded. User is redirected back to company step.

Workaround:

None found. Onfido is blocked on mWeb.

Platform:

Where is this issue occurring?

Mobile Web

Version Number: 1.1.10-0

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

MelvinBot · 2021-10-27T18:42:34Z

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

OSBotify · 2021-10-27T18:45:10Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

roryabraham · 2021-10-27T22:11:17Z

@jasperhuangg Did you mean to close this?

roryabraham · 2021-10-27T22:18:59Z

I'm assuming that was a mistake because this was closed without a comment or PR, reopening.

kavimuru · 2021-10-27T22:41:07Z

@jasperhuangg @roryabraham Adding video for the above bug.

20211027_183524.mp4

roryabraham · 2021-10-27T22:42:41Z

@kavimuru Can you confirm the account(s) you used to test this? kavi.utest+chatd@gmail.com ?

roryabraham · 2021-10-27T22:46:42Z

Logs don't appear to reveal much 😕 :

[hmmm] Onfido error in RequestorStep ~~ error: 'Unknown error' userAgent: 'Mozilla/5.0 (Linux; Android 10; SM-G973W) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.50 Mobile Safari/537.36'

jasperhuangg · 2021-10-27T23:06:34Z

Looks like there isn't enough information to go off of to debug this.

To summarize, the growl is how we handle an error returned by the Onfido API. Here's how that error is shaped (taken from the Onfido SDK npm package)

export declare type SdkError = {
	type: "exception" | "expired_token";
	message: string;
};

We only log the message here, and since the error we get back doesn't have a message to pass into the growl, we default to CONST.ERROR.UNKNOWN_ERROR i.e. Unknown error.

@roryabraham Is there any chance we can deploy something that changes the log to include the type parameter and get @kavimuru to retry? Or is it better at this point to revert the PR?

roryabraham · 2021-10-27T23:06:45Z

I assume yes, but have we confirmed that this issue is not present on production?

jasperhuangg · 2021-10-27T23:07:18Z

have we confirmed that this issue is not present on production?

Not yet, only verified on staging, on that right now.

roryabraham · 2021-10-27T23:08:16Z

@roryabraham Is there any chance we can deploy something that changes the log to include the type parameter and get @kavimuru to retry?

Of course, this is possible.

Or is it better at this point to revert the PR?

What PR?

isagoico · 2021-10-27T23:09:43Z

We were unable to reproduce this issue in production on our side.

jasperhuangg · 2021-10-27T23:11:48Z

What PR?

@roryabraham Right sorry, forgot we don't know where this is coming from.

Just tested it myself on production and didn't run into it, so it looks like this is a regression. I'll start scanning through any relevant App PRs.

roryabraham · 2021-10-27T23:14:34Z

One thing that's worth noting is that E/App staging points at the production Web-E API, but at the staging Web-S API. So the regression could have been caused in https://github.com/Expensify/Web-Secure

roryabraham · 2021-10-27T23:26:42Z

I'm far from certain, but this PR seems like a potential suspect to me.

jasperhuangg · 2021-10-27T23:29:58Z

@roryabraham After some investigation I think the error should be self-contained within the Onfido API, I don't think this part of the flow touches Web-S. Especially since switching between staging/prod for NewDot fixes the issue.

As for https://github.com/Expensify/App/pull/5975/files, it looks like the functions that were changed are only called within the onFieldChange prop for IdentityForm, which I also don't think is invoked by the Onfido flow.

I think we should deploy #6091 and get more information first.

jasperhuangg · 2021-10-27T23:31:40Z

Also unrelated but this deploy blocker isn't showing up in my K2

jasperhuangg · 2021-10-28T00:08:01Z

Ah, after some poking around @roryabraham and I figured out that it's actually the browser blocking the request to upload the ID picture to this endpoint.

If you're wondering why I have a screenshot of the Network tab from the Desktop version of Chrome (even though this is a mobile web issue): Onfido only allows us to upload documents from a mobile client. However Onfido doesn't actually check the user-agent–their JS just checks the screen size–meaning we can reproduce this on any browser.

@justinpersaud Looks like this has to do with the CSP we've enabled for staging. Do you think it's safe to get rid of this deploy blocker?

marcaaron · 2021-10-28T00:31:47Z

Do you think it's safe to get rid of this deploy blocker?

Let's fix the CSP issue, retest, then remove the blocker?

roryabraham · 2021-10-28T00:34:37Z

More details on the CSP errors:

index.js:26 Refused to load the script 'https://www.woopra.com/track/ce/?ra=rkQQmI5tHL4a&alias=onfido-js-sdk.com&instance=onfidojssdkwoopra&ka=24000&meta=&screen=375x812&language=en-US&app=js-client&referer=&idle=0&vs=r&cookie=e7m1bmxiirrV&event=started%20flow&cv_sdk_version=6.8.0&cv_client=staging.new.expensify.com&ce_is_custom_ui=true' because it violates the following Content Security Policy directive: "script-src 'self' https://polyfill.io https://cdn.plaid.com". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.
...
...
Refused to connect to 'https://api.onfido.com/v3/documents' because it violates the following Content Security Policy directive: "connect-src 'self' https://*.pusher.com wss://*.pusher.com https://*.pusherapp.com https://staging-secure.expensify.com https://www.expensify.com wss://sync.onfido.com https://telephony.onfido.com blob:".
...
Refused to connect to 'https://sentry.io/api/109946/store/?sentry_key=6e3dc0335efc49889187ec90288a84fd&sentry_version=7' because it violates the following Content Security Policy directive: "connect-src 'self' https://*.pusher.com wss://*.pusher.com https://*.pusherapp.com https://staging-secure.expensify.com https://www.expensify.com wss://sync.onfido.com https://telephony.onfido.com blob:".

justinpersaud · 2021-10-28T00:48:07Z

Let's fix it instead of just pushing to production. CSP was never enabled in production yet, and is on hold right now.

It can be updated here https://github.com/Expensify/Cloudflare-Workers/blob/master/new.expensify.com/wrangler.toml#L12

roryabraham · 2021-10-28T02:58:11Z

Got a PR up to hopefully fix this:

https://github.com/Expensify/Cloudflare-Workers/pull/15

It's approved, but we need it to be merged and deployed by ring0 before we can retest.

roryabraham · 2021-10-28T03:15:53Z

Reopening for testing

roryabraham · 2021-10-28T03:19:05Z

Verified this is fixed, closing this out 🎉

marcaaron · 2021-10-28T05:00:26Z

Thanks @roryabraham !! 🙇‍♂️

bondydaa · 2021-10-28T15:41:07Z

I think this was from Jasper testing this before the fix was out right? https://github.com/Expensify/Expensify/issues/182916

roryabraham · 2021-10-28T16:44:10Z

I think this was from Jasper testing this before the fix was out right?

Yep, looks like it

isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Oct 27, 2021

MelvinBot assigned jasperhuangg Oct 27, 2021

OSBotify mentioned this issue Oct 27, 2021

Deploy Checklist: New Expensify 2021-10-23 #6017

Closed

github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Oct 27, 2021

jasperhuangg closed this as completed Oct 27, 2021

roryabraham reopened this Oct 27, 2021

jasperhuangg mentioned this issue Oct 27, 2021

[CP Staging] Include more information in Onfido API error handling #6091

Closed

fukawi2 closed this as completed Oct 28, 2021

roryabraham reopened this Oct 28, 2021

roryabraham closed this as completed Oct 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mWeb - Error message displayed when trying to upload document on onfido flow and user is redirected to Company step #6085

mWeb - Error message displayed when trying to upload document on onfido flow and user is redirected to Company step #6085

isagoico commented Oct 27, 2021

MelvinBot commented Oct 27, 2021

OSBotify commented Oct 27, 2021

roryabraham commented Oct 27, 2021

roryabraham commented Oct 27, 2021

kavimuru commented Oct 27, 2021

roryabraham commented Oct 27, 2021

roryabraham commented Oct 27, 2021

jasperhuangg commented Oct 27, 2021

roryabraham commented Oct 27, 2021

jasperhuangg commented Oct 27, 2021

roryabraham commented Oct 27, 2021

isagoico commented Oct 27, 2021

jasperhuangg commented Oct 27, 2021 •

edited

Loading

roryabraham commented Oct 27, 2021

roryabraham commented Oct 27, 2021

jasperhuangg commented Oct 27, 2021 •

edited

Loading

jasperhuangg commented Oct 27, 2021

jasperhuangg commented Oct 28, 2021 •

edited

Loading

marcaaron commented Oct 28, 2021

roryabraham commented Oct 28, 2021

justinpersaud commented Oct 28, 2021

roryabraham commented Oct 28, 2021 •

edited

Loading

roryabraham commented Oct 28, 2021

roryabraham commented Oct 28, 2021

marcaaron commented Oct 28, 2021

bondydaa commented Oct 28, 2021

roryabraham commented Oct 28, 2021

mWeb - Error message displayed when trying to upload document on onfido flow and user is redirected to Company step #6085

mWeb - Error message displayed when trying to upload document on onfido flow and user is redirected to Company step #6085

Comments

isagoico commented Oct 27, 2021

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

MelvinBot commented Oct 27, 2021

OSBotify commented Oct 27, 2021

roryabraham commented Oct 27, 2021

roryabraham commented Oct 27, 2021

kavimuru commented Oct 27, 2021

roryabraham commented Oct 27, 2021

roryabraham commented Oct 27, 2021

jasperhuangg commented Oct 27, 2021

roryabraham commented Oct 27, 2021

jasperhuangg commented Oct 27, 2021

roryabraham commented Oct 27, 2021

isagoico commented Oct 27, 2021

jasperhuangg commented Oct 27, 2021 • edited Loading

roryabraham commented Oct 27, 2021

roryabraham commented Oct 27, 2021

jasperhuangg commented Oct 27, 2021 • edited Loading

jasperhuangg commented Oct 27, 2021

jasperhuangg commented Oct 28, 2021 • edited Loading

marcaaron commented Oct 28, 2021

roryabraham commented Oct 28, 2021

justinpersaud commented Oct 28, 2021

roryabraham commented Oct 28, 2021 • edited Loading

roryabraham commented Oct 28, 2021

roryabraham commented Oct 28, 2021

marcaaron commented Oct 28, 2021

bondydaa commented Oct 28, 2021

roryabraham commented Oct 28, 2021

jasperhuangg commented Oct 27, 2021 •

edited

Loading

jasperhuangg commented Oct 27, 2021 •

edited

Loading

jasperhuangg commented Oct 28, 2021 •

edited

Loading

roryabraham commented Oct 28, 2021 •

edited

Loading