The option rows in the Streamline payments use an old, rounded pill hover style

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.10-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Navigate to Add Bank account flow in workspace settings
2. Hover on the option Log into your bank or Connect manually

Expected Result:

These should use a full-bleed style, consistent with other option rows.

Actual Result:

The option rows in the Streamline payments use an old, rounded pill hover style

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Expected Result:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The option rows in the Streamline payments use an old, rounded pill hover style

What is the root cause of that problem?

We're using cardMenuItem styles which include the deprecated style:

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Line 234 in a49c13a

wrapperStyle={[styles.cardMenuItem, styles.mt4]}

What changes do you think we should make in order to solve the problem?

1. Remove styles.cardMenuItem.
2. Set outerWrapperStyle={shouldUseNarrowLayout ? styles.mhn5 : styles.mhn8} to apply the negative margin.

Check all the places using styles.cardMenuItem to apply the same fix. I already found 8 places in 6 pages. For example in GetAssistancePage

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None - Minor UI update

What alternative solutions did you explore? (Optional)

None

[skg0525]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The option rows in the Streamline payments use an old, rounded pill hover style

What is the root cause of that problem?

I agree with @gijoe0295 the problem is its using styles.cardMenuItem but my solution is different from their's

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Lines 228 to 236 in a49c13a

	<MenuItem
	title={translate('workspace.bankAccount.continueWithSetup')}
	icon={Connect}
	iconFill={theme.icon}
	onPress={onContinuePress}
	shouldShowRightIcon
	wrapperStyle={[styles.cardMenuItem, styles.mt4]}
	disabled={!!pendingAction || !isEmptyObject(errors)}
	/>

App/src/styles/index.ts

Lines 3914 to 3920 in 9702e89

	cardMenuItem: {
	paddingLeft: 8,
	paddingRight: 0,
	borderRadius: variables.buttonBorderRadius,
	height: variables.componentSizeLarge,
	alignItems: 'center',
	},

What changes do you think we should make in order to solve the problem?

We should change the style itself (i.e remove 'paddingLeft', 'paddingRight', and add width: 'auto' & borderRadius: 0). which is change the cardMenuItem like this below
cardMenuItem: { width: 'auto', borderRadius: 0, height: variables.componentSizeLarge, alignItems: 'center', },

This way we wont have to update the code at many places and yet change the style at all the places its being used.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.