Android - Workflows - Device back gesture on Workflows page directly returns to Workspace list

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Workspace Settings

Action Performed:

1. Launch ND or hybrid app.
2. Go to Workspace settings.
3. Go to Workflows.
4. Use device back button or device back gesture to go back.

Expected Result:

App will return to workspace editor.

Actual Result:

App returns two steps back to workspace list.

This issue also happens in Rules and Report fields page, and is not reproducible on Members and Categories page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6763758_1741337961965.1741337822782_Screen_Recording_20250307_165630_New_Expensify.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns two steps back to workspace list.

What is the root cause of that problem?

when we press the device back button we are using the goBack function here

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 187 in c7aa2c1

onBackButtonPress={() => (onBackButtonPress ? onBackButtonPress() : Navigation.goBack(backButtonRoute))}

What changes do you think we should make in order to solve the problem?

We should use hook useHandleBackButton like we did with WorkspaceListPage here

   const goBack = () => {
        if(!!onBackButtonPress){
            onBackButtonPress();
        } else {
            Navigation.goBack(backButtonRoute);
        }
        return true;
    }
    useHandleBackButton(goBack);

And update the onBackButtonPress in HeaderWithBackButton to goBack function

      onBackButtonPress={goBack}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[cristipaval]

I suspect this is the offending PR. Looking 👀

[cristipaval]

Demoting this one. We're discussing about a good fix here

[IuliiaHerets]

@cristipaval @johncschuster @nkuoch QA team found the similar issue. Is it the same root or we need to open a new one?

Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): testpayment935+57be@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy S10 5G - Android 12
App Component: Workspace Settings

Action Performed:

1. Open Hybrid android app
2. Create WS and enable tag
3. Navigate to tag page and click add tag
4. Click device back button and notice it navigates to workspace setting rather than tag list page
5. Navigate to tag page and click setting
6. Click device back button and notice it navigates to workspace setting rather than tag list page
7. Navigate to tag page and click 3 dot
8. Choose Import spreadsheet
9. Click device back button and notice it navigates to workspace setting rather than tag list page
10. Repeat step 3 to step 9 for category and notice every step leads to workspace setting rather than category list page

Expected Result:

Device back buttons leads to category or tag list rather than the main workspace setting

Actual Result:

Device back button leads to workspace setting rather than category or tag list

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6764014_1741354965194.B3.mp4

View all open jobs on GitHub

[cristipaval]

I suspect this is the offending PR. Looking 👀

I can confirm the offending PR. I reproduced the current issue locally, reverted the above PR, and that fixed the issue.

[cristipaval]

@IuliiaHerets, let's not create other issues. All Workspace Settings pages that go back to the workspace list when hitting the hardware back button on Android have the same root cause.

[daledah]

@cristipaval I'll open follow-up soon.

[cristipaval]

@Ollyws I assigned you as the C+, since you reviewed the offending PR

[daledah]

@Ollyws PR is ready.