[HOLD][$250] mWeb - Onboarding - Onboarding modal can be dismissed using device´s back button.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.6-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+313@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Other

Action Performed:

1. Open the staging.new.expensify.com website.
2. Sign up with a new account.
3. When onboarding modal is displayed, use device´s back button. (More than once if no action is displayed)
4. Check the onboarding modal behaviour with this action.

Expected Result:

User shouldn´t be able to dismiss the onboarding modal.

Actual Result:

Onboarding modal can be dismissed by using device´s back button. User lands on inbox and can continue to navigate the website normally.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6754575_1740543032891.Onboarding.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894759193596113336
• Upwork Job ID: 1894759193596113336
• Last Price Increase: 2025-02-26

Issue Owner

Current Issue Owner: @ntdiary

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894759193596113336

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[Gonals]

I don't think we need to block deploy on this, as it is pretty minor and exclusive of Android Web

[OmarKoueifi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user signs up, the onboarding modal appears. However, pressing the device’s back button on mWeb Android dismisses the modal, allowing the user to access the inbox and navigate the website. This leads to an unintended behavior where users can bypass the onboarding flow.

What is the root cause of that problem?

The current implementation does not intercept the back button press when the user is on the onboarding screen (/onboarding/purpose).

What changes do you think we should make in order to solve the problem?

To prevent the modal from closing when on /onboarding/purpose, I will use the useFocusEffect hook from @react-navigation/native in OnboardingModalNavigator.tsx. This will:

• Intercept the back button press.
• Prevent navigation when the user is on the onboarding modal.
• Allow default behavior when the user is on other screens.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Screen recordings:

• Reproducing the issue was different in my case

Screen.Recording.2025-02-26.at.10.47.32.AM.mov

• With my proposed solution:

Screen.Recording.2025-02-26.at.10.48.28.AM.mov

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[ikevin127]

⚠️ Looks like a duplicate of:

• [$250] mWeb - Sign In - Using device back button after onboarding, leads to "It's not here" page. #57080

[ntdiary]

I couldn't reproduce this issue on the latest main branch.

test1.mov

[michaelkwardrop]

Looks like #57080 is slightly different, (this is before onboarding is completed, and that issue is unique to after onboarding is completed) but I bet they could be fixed together.

[michaelkwardrop]

That being said, putting this on HOLD because it doesn't look like it's an issue anymore. I still don't have BrowserStack access, but I'll try to reproduce tomorrow using the Android phone at the bank.

[OmarKoueifi]

I just pulled latest main, and I can't reproduce anymore

[michaelkwardrop]

Great, let's close this out - sounds like it was fixed by a recent PR.

[michaelkwardrop]

Closed the Upwork job, removed Help Wanted