[Due for payment 2025-03-11] [$250] Do not allow to enter issue expensify card flow unless the policy is provisioned

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C07HPDRELLD/p1740392771429119

Action Performed:

Break down in numbered steps

1. Enable the Expensify Card feature but doesn't settle bank account
2. Go to member page
3. Click on the member detail
4. Click on the Add card
5. Select the Expensify Card

Expected Result:

Describe what you think should've happened

We shouldn't display the Expensify option if users haven't connected their bank account and the cards have not been setup fully

Actual Result:

Describe what actually happened

Admin can enter this flow leading to error inevitably

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894333795848558635
• Upwork Job ID: 1894333795848558635
• Last Price Increase: 2025-02-25
• Automatic offers:
• DylanDylann | Reviewer | 106270114

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894333795848558635

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[koko57]

I would like to work on this issue 🙋‍♀

[koko57]

I've also found an issue with the loader showing infinitely (until refresh or changing route and going back) #55124 (comment) when investigating #55124. If it's a simple fix I could fix both issues in one PR

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[mountiny]

Thanks!

[koko57]

Ok, so the problem with the loader is a more complex one - when creating a workspace offline and then enabling Expensify Card (also offline) and then going back online

I'm getting Unauthorized Request for OpenPolicyProfilePage and OpenPolicyExpensifyCardPage and also I cannot delete the workspace (the error also in the screenshot)

So I will open the PR for displaying the card issue and I will check if the problem I described here was already reported and there is a separate ticket for that. If not I think we should open another issue

cc @mountiny @DylanDylann

[koko57]

PR opened for review #57407

[koko57]

I was about to open the issue for the loader, but I've found out that it's already opened. #57106. If the proposal won't be correct and accepted I can investigate this further.

cc @mountiny

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.8-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: do not show Expensify Card when not fully set up #57407

If no regressions arise, payment will be issued on 2025-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

@DylanDylann @bfitzexpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[bfitzexpensify]

@DylanDylann please complete the BZ checklist

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: [No QA] Feat/47377 multiple card feeds #49148 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Enable the Expensify Card feature but doesn't have settle bank account
2. Go to member page
3. Click on the member detail
4. Click on the Add card
5. Verify that the Expensify Card option is not displayed
6. Go to a workspace where the Expensify Card is enabled and the account is set
7. Repeat steps 2-4
8. Verify that the Expensify Card option is displayed

Do we agree 👍 or 👎

[bfitzexpensify]

Thanks @DylanDylann. Payment complete, closing this out.