[HOLD on payment] [$250] PR56048-Invoice-The text in the title field in Details and the editable field don't match

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56048
Email or phone of affected tester (no customers): agexptest+pr0602@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: Money Requests

Action Performed:

Precondition: Have a workspace created with invoice feature enabled.

1. Go to https://staging.new.expensify.com/
2. Send an invoice
3. Open the invoice created
4. Open the invoice header
5. Click on the Title field

Expected Result:

The text in the title field in Details and the editable field matches.

Actual Result:

The text in the title field in Details and the editable field don't match.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6735791_1738892948993.Unmatch_texts.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021889071920301448517
• Upwork Job ID: 1889071920301448517
• Last Price Increase: 2025-02-10
• Automatic offers:
• shubham1206agra | Contributor | 106073218

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Seems like coming from this PR: #50135

[mallenexpensify]

@zfurtak @DylanDylann , 👀 plz, to see if #50135 is the offending PR. Thanks @NJ-2020 for commenting.

[zfurtak]

I will look into it

[zfurtak]

I'll be out of office this week, but I can take care of this issue on Monday.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021889071920301448517

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[luacmartins]

This actually comes from #56048. It seems like we want to use the ... owes pattern in ND, but once we click into the menu item, the populated name is the OD one.

[luacmartins]

Demoting and assigning it to the original authors

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[rezkiy37]

@cristipaval, I would like to clarify the expected result. Normally, the app restricts the editing of invoice titles. Moreover, the app must show the owes pattern for ND invoices. However, the backend always uses the Invoice AAAA-MM-DD format for reportName. It looks like an edge case. We need to hide the editable field for such cases.

OD invoices work properly

Screenshot

ND invoices work wrong

Screenshot

[rezkiy37]

Draft PR - #56675.

[cristipaval]

@rezkiy37, I agree with you. Editing the ND invoice titles makes no sense. Let's block the user from editing any invoice title, whether it was created in OD or ND. We'll take care of this as part of the invoice cross-compatibility project when it is prioritized again.

[rezkiy37]

I've opened for review - #56675.

[rezkiy37]

I’m planning a short vacation next week from Monday to Wednesday, from the 17th to the 19th. I am working on the issue later. Meanwhile, I've asked my colleagues to help me here.

[luacmartins]

Thanks for the heads up @rezkiy37! Enjoy your time off.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Restrict editing of titles for ND invoices. #56675

If no regressions arise, payment will be issued on 2025-02-25. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

@shubham1206agra @mallenexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mallenexpensify]

@shubham1206agra can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021889071920301448517

[shubham1206agra]

@mallenexpensify I have asked you about payment here https://expensify.slack.com/archives/D06LR00V5R8/p1740427241673359

[mallenexpensify]

Holding for a min for payment, per @shubham1206agra 's request. Made it a weekly and made you issue owner @shubham1206agra , updated title too.