[Due for payment 2025-02-13] iOS - Wallet - App returns to previous steps when using device gesture on success page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: User Settings

Action Performed:

Precondition:

• User has assigned themselves a virtual card.

1. Go to staging.new.expensify.com
2. Go to Wallet.
3. Tap on the card.
4. Tap Report virtual card fraud.
5. Tap Deactivate card.
6. Enter magic code.
7. On success page, use device gesture to go back (swipe to right on iOS).

Expected Result:

App will return to Wallet page.

Actual Result:

App returns to previous deactivating card steps.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6728130_1738205821566.ScreenRecording_01-30-2025_10-53-09_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @michaelkwardrop

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[techievivek]

@burczu Seems like this might have originated from your PR here #55278

[burczu]

@techievivek Yes, it seems you are right - this looks like a regression from my PR you've mentioned above. Please assign me - I'll work on fixing it. Thanks

[mountiny]

Happy to take over as I have worked with @burczu on the PR

[burczu]

@mountiny This one is quite tricky actually - I was able to fix it partially, by calling Navigate.closeAndNavigate to open the success page. It closes the Report Virtual Card page before showing the Success page, and this is what we need. Then, when the user slides right using gestures, it lands on the Card Details Page (which is correct). Unfortunately this page is not updated with the new cardID so it shows $0.00 etc. (when user taps Got it! or the Go Back button it is actually navigated to the new Card Details Page with correct cardID).

I think we may need to handle this gesture programmatically using react-native-gesture-handle here. What do you think? Any other ideas?

[burczu]

@mountiny Ok, I have another idea, but it may look kinda' hack'ish - we can remove the Card details page from the stack while we redirecting to the Success page: this way when user uses gestures to close the page, it will land on the Settings -> Wallet page... If they tap on Got it button or on the Go back button it will land on correct Card details page as before. WDYT?

[mountiny]

Demoting as the users are not blocked by this action and its mainly about specific ux flow, i dont want to make rushed decisions

[mountiny]

Discussing in the slack thread

[burczu]

The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Proper back navigation handling in card deactivation success page #56070

If no regressions arise, payment will be issued on 2025-02-13. 🎊

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @alitoshmatov requires payment through NewDot Manual Requests

[melvin-bot]

@alitoshmatov @michaelkwardrop @alitoshmatov The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@burczu @mountiny @alitoshmatov @michaelkwardrop this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @burczu is from an agency-contributor and not due payment
• Reviewer: @alitoshmatov owed $0 via NewDot (regression)

BugZero Checklist (@michaelkwardrop)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[alitoshmatov]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/55278/files#r1954225671

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1738211261080969

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

No regression is needed

[alitoshmatov]

This was a regression so no payment needed

[michaelkwardrop]

Closing, no payment needed (regression). Confirming this job was not added to Upwork, so there is no posting to delete.