[HOLD for payment 2024-03-05] [$250] iOS Hybrid - Sign in - The app does not auto suggest the magic code from email to sign in

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found while executing QA for PR #54755

Version Number: 9.0.89.5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #54755
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 15 iOS 18.1.1
App Component: Other

Action Performed:

1. Open staging Hybrid app
2. Select Continue with Email option on the Welcome screen
3. Enter the email address that is added to your iOS mail app
4. Tap Next
5. Open the mail app and wait for the code to arrive, don't open it
6. Go back to the Hybrid app and make sure that it auto suggests the magic code

Expected Result:

Hybrid app auto suggests the magic code from the email to sign in with, as in ND Standalone app.

Actual Result:

Hybrid app does not auto suggest the magic code from email to sign in

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

bug2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884130584906000105
• Upwork Job ID: 1884130584906000105
• Last Price Increase: 2025-01-28
• Automatic offers:
• brunovjk | Reviewer | 105889014
• ZhenjaHorbach | Contributor | 106254084

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884130584906000105

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[hannojg]

This screen:

Is part of the old app's code (https://github.com/Expensify/Mobile-Expensify), thus it's not a bug from this code base.

[hannojg]

Not sure if issues for the old app's code are tracked in this repository?

[melvin-bot]

📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[brunovjk]

I'm having a hard time reproducing this issue, I still haven't been able to install "mail app" on my simulator.

[mountiny]

@hannojg have you been able to setup the hybrid app and look into this?

[melvin-bot]

@hannojg @stephanieelliott @mountiny @brunovjk this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[stephanieelliott]

Hey @brunovjk, any luck looking into this yet?

[brunovjk]

Not yet @stephanieelliott, I still haven't been able to reproduce it because of the iOS Mail App, today I'll try some alternative ways and let you know. Thanks.

[hannojg]

Got the hybrid app working and I am able to reproduce! Will look into fixing this now …

[hannojg]

Opened a PR here that fixes the issue:

• https://github.com/Expensify/Mobile-Expensify/pull/13438

[brunovjk]

Should I review it @hannojg? Thanks

[hannojg]

@brunovjk you're a C+ ? Not sure how it works since it's a direct change / PR towards the Mobile-expensify repo. cc @mountiny

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ZhenjaHorbach]

@stephanieelliott
Can we make a payment here, please ?
And I accepted an offer

[stephanieelliott]

@ZhenjaHorbach you're requesting payment for C+ review of https://github.com/Expensify/Mobile-Expensify/pull/13438 right? Or is there a different one?

If it's https://github.com/Expensify/Mobile-Expensify/pull/13438 the payment be queued for the date the PR hits prod+ 7 days.

[ZhenjaHorbach]

@ZhenjaHorbach you're requesting payment for C+ review of Expensify/Mobile-Expensify#13438 right? Or is there a different one?

If it's Expensify/Mobile-Expensify#13438 the payment be queued for the date the PR hits prod+ 7 days.

Sorry 😅
It's just that this issue was closed for a short period of time
I thought we weren't going to wait for regression period

But now yes
Let's wait !

[stephanieelliott]

No worries! All good 😅, will pay this one out at the end of the regression period

[stephanieelliott]

I think this should've went out with the 2/26 deploy, which would make payment due tomorrow. Queuing for payment on 3/5

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @ZhenjaHorbach $250 $250 via Upwork - PAID!
• Contributor+: @brunovjk $250 via Upwork - PAID!

Upwork job is here: https://www.upwork.com/jobs/~021884130584906000105