Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-27] [$250] Up and down arrows not working in the composer sometimes #55734

Closed
2 of 8 tasks
mountiny opened this issue Jan 24, 2025 · 16 comments
Closed
2 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@mountiny
Copy link
Contributor

mountiny commented Jan 24, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar @mallenexpensify
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C049HHMV9SM/p1737670596476479

Action Performed:

Break down in numbered steps

  1. Go to Reports page
  2. Go back to inbox
  3. Open some report
  4. Start writing a message
  5. Make it multi line
  6. Try to move "up" to the previous line -- it doesn't work

Expected Result:

Describe what you think should've happened

You should be able to move the cursor within the message

Actual Result:

Describe what actually happened

Unable to move through the composed message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021882813733020527368
  • Upwork Job ID: 1882813733020527368
  • Last Price Increase: 2025-01-24
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @jliexpensify
@mountiny mountiny added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 24, 2025
@mountiny mountiny self-assigned this Jan 24, 2025
Copy link

melvin-bot bot commented Jan 24, 2025

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Skalakid
Copy link
Contributor

Hello, here is the PR with the fix

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jan 24, 2025
@melvin-bot melvin-bot bot changed the title Up and down arrows not working in the composer sometimes [$250] Up and down arrows not working in the composer sometimes Jan 24, 2025
Copy link

melvin-bot bot commented Jan 24, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021882813733020527368

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 24, 2025
Copy link

melvin-bot bot commented Jan 24, 2025

Current assignee @dominictb is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 24, 2025
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 24, 2025
@muttmuure muttmuure removed their assignment Feb 14, 2025
@muttmuure muttmuure added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 14, 2025
Copy link

melvin-bot bot commented Feb 14, 2025

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 14, 2025
@jliexpensify
Copy link
Contributor

It looks like @Skalakid needs to address comments in the PR. No action from B0 yet.

@mallenexpensify mallenexpensify removed the Reviewing Has a PR in review label Feb 18, 2025
@mallenexpensify
Copy link
Contributor

Removed Reviewing, made a MEDIUM on #quality and added @Skalakid as issue owner so it'll go overdue. Just experienced the issues again.

Looks like progress is being made on the PR the past few days, let try to wrap this one up (while also knowing that this is real "Sorry, had to finish some tasks with higher priority. Looking into this right now)

@Skalakid
Copy link
Contributor

Hello, the PR is finished, approved by C+, and now I'm waiting for the review from an internal

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title [$250] Up and down arrows not working in the composer sometimes [Due for payment 2025-02-27] [$250] Up and down arrows not working in the composer sometimes Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.2-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

  • @Skalakid does not require payment (Contractor)
  • @dominictb requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Feb 20, 2025

@dominictb @jliexpensify @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@jliexpensify
Copy link
Contributor

Payment Summary

https://www.upwork.com/jobs/~021882813733020527368

@jliexpensify
Copy link
Contributor

Bumping @dominictb for a checklist

@dominictb
Copy link
Contributor

on it now

@dominictb
Copy link
Contributor

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/54797/files#r1970841412

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal

Test:

  1. Enter any chat
  2. Write some multiline text
  3. Got to Reports page
  4. Go back to the Inbox and to the chat that you wrote earlier
  5. Verify if you can move cursor using up and down arrow

Do we agree 👍 or 👎

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 27, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Payment Summary

Upwork Job

  • Contributor: @Skalakid is from an agency-contributor and not due payment
  • ROLE: @dominictb paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@jliexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1882813733020527368/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@jliexpensify
Copy link
Contributor

Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

6 participants