Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Due for payment 2025-02-10] Not prompting to authenticate with the bank if the credentials have expired when assigning cards from workspace member profile. #55104

Closed
1 of 8 tasks
m-natarajan opened this issue Jan 10, 2025 · 38 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@m-natarajan
Copy link

m-natarajan commented Jan 10, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): convert

Action Performed:

Precondition: Credential status in expired condition for assigning cards

  1. Navigate to members section of a Workspace where company cards are enabled and added
  2. Select a member and click + new card
  3. Select Card and click Next

Expected Result:

Authentication page displayed to assign the card

Actual Result:

Authentication page not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
2025-01-10_14-11-29.1.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021887999200239734379
  • Upwork Job ID: 1887999200239734379
  • Last Price Increase: 2025-02-07
Issue OwnerCurrent Issue Owner: @VictoriaExpensify
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 10, 2025
Copy link

melvin-bot bot commented Jan 10, 2025

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@allgandalf
Copy link
Contributor

Please assign me here, this seems to be similar to the PR we worked on @waterim

@mountiny mountiny assigned mountiny and unassigned allgandalf Jan 12, 2025
@mountiny mountiny removed the Needs Reproduction Reproducible steps needed label Jan 12, 2025
@mountiny mountiny moved this to In Progress in [#whatsnext] #convert Jan 12, 2025
@mountiny mountiny moved this from In Progress to Todo in [#whatsnext] #convert Jan 12, 2025
@mountiny mountiny moved this from MEDIUM to HIGH in [wave-collect] Workspace Feeds Jan 12, 2025
@mountiny
Copy link
Contributor

@allgandalf We are going to spread these out, the project is in a latter phase now

@waterim will take this one

@kadiealexander
Copy link
Contributor

Thanks @mountiny I was having trouble figuring out how to repro this one.

@narefyev91
Copy link
Contributor

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

@mountiny
Copy link
Contributor

@narefyev91 any updates?

@narefyev91
Copy link
Contributor

@narefyev91 any updates?

PR will be up in about 20 mins

@Pujan92
Copy link
Contributor

Pujan92 commented Jan 16, 2025

@mountiny Shall I review the PR as I am auto assigned or @allgandalf needs to do it?

@mountiny
Copy link
Contributor

@Pujan92 please go ahead, but I think you cannot test this easily

@Pujan92
Copy link
Contributor

Pujan92 commented Jan 17, 2025

Ok, I will check.

Copy link

melvin-bot bot commented Feb 3, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-10. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 3, 2025

@allgandalf @kadiealexander @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@kadiealexander kadiealexander changed the title [Due for payment 2025-02-10] [HOLD for payment 2025-02-04] Not prompting to authenticate with the bank if the credentials have expired when assigning cards from workspace member profile. [Due for payment 2025-02-10] Not prompting to authenticate with the bank if the credentials have expired when assigning cards from workspace member profile. Feb 4, 2025
@kadiealexander kadiealexander added the External Added to denote the issue can be worked on by a contributor label Feb 7, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-02-10] Not prompting to authenticate with the bank if the credentials have expired when assigning cards from workspace member profile. [$250] [Due for payment 2025-02-10] Not prompting to authenticate with the bank if the credentials have expired when assigning cards from workspace member profile. Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021887999200239734379

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Feb 7, 2025
@kadiealexander
Copy link
Contributor

Payment summary:

Upwork job

I'm OOO for the next week so reassigning for someone to handle payment.

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2025
@kadiealexander kadiealexander removed the Bug Something is broken. Auto assigns a BugZero manager. label Feb 7, 2025
@kadiealexander kadiealexander removed their assignment Feb 7, 2025
@kadiealexander kadiealexander added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@abdulrafay155
Copy link

abdulrafay155 commented Feb 8, 2025

I Implement a conditional check that triggers a secure re-authentication prompt when expired bank credentials are detected during card assignment. This will fix the issue

Contributor details
Your Expensify account email: ar61087045@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~017ba58e2734b48e28

Copy link

melvin-bot bot commented Feb 8, 2025

📣 @abdulrafay155! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@abdulrafay155
Copy link

Contributor details
Your Expensify account email: ar61087045@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~017ba58e2734b48e28

Copy link

melvin-bot bot commented Feb 8, 2025

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@allgandalf
Copy link
Contributor

Payment today 💃

@melvin-bot melvin-bot bot added the Overdue label Feb 10, 2025
@VictoriaExpensify
Copy link
Contributor

Is @abdulrafay155 due any payment on this? They are not assigned to the issue and it's not evident that they have contributed to it, but I see they have been prompted to add their Upwork details.

@mountiny @allgandalf can you shed any light here?

@melvin-bot melvin-bot bot removed the Overdue label Feb 10, 2025
@VictoriaExpensify
Copy link
Contributor

Payment Summary:

Reviewer: @allgandalf paid $250 via Upwork (offer)
Upwork job

@allgandalf
Copy link
Contributor

@VictoriaExpensify we're good to close this issue, @abdulrafay155 didn't contribute to this issue, but we do want to see @abdulrafay155 around posting proposals for other help wanted issues 😄

@VictoriaExpensify
Copy link
Contributor

Awesome, thanks for confirming @allgandalf. Look forward to your future proposals @abdulrafay155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Development

No branches or pull requests

9 participants