-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [Due for payment 2025-02-10] Not prompting to authenticate with the bank if the credentials have expired when assigning cards from workspace member profile. #55104
Comments
Triggered auto assignment to @kadiealexander ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Please assign me here, this seems to be similar to the PR we worked on @waterim |
@allgandalf We are going to spread these out, the project is in a latter phase now @waterim will take this one |
Thanks @mountiny I was having trouble figuring out how to repro this one. |
Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue. |
@narefyev91 any updates? |
PR will be up in about 20 mins |
@mountiny Shall I review the PR as I am auto assigned or @allgandalf needs to do it? |
@Pujan92 please go ahead, but I think you cannot test this easily |
Ok, I will check. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-10. 🎊 For reference, here are some details about the assignees on this issue:
|
@allgandalf @kadiealexander @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Job added to Upwork: https://www.upwork.com/jobs/~021887999200239734379 |
Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new. |
Payment summary:
I'm OOO for the next week so reassigning for someone to handle payment. |
Triggered auto assignment to @VictoriaExpensify ( |
I Implement a conditional check that triggers a secure re-authentication prompt when expired bank credentials are detected during card assignment. This will fix the issue Contributor details |
📣 @abdulrafay155! 📣
|
Contributor details |
|
Payment today 💃 |
Is @abdulrafay155 due any payment on this? They are not assigned to the issue and it's not evident that they have contributed to it, but I see they have been prompted to add their Upwork details. @mountiny @allgandalf can you shed any light here? |
Payment Summary: Reviewer: @allgandalf paid $250 via Upwork (offer) |
@VictoriaExpensify we're good to close this issue, @abdulrafay155 didn't contribute to this issue, but we do want to see @abdulrafay155 around posting proposals for other |
Awesome, thanks for confirming @allgandalf. Look forward to your future proposals @abdulrafay155 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): convert
Action Performed:
Precondition: Credential status in expired condition for assigning cards
Expected Result:
Authentication page displayed to assign the card
Actual Result:
Authentication page not displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
2025-01-10_14-11-29.1.1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @VictoriaExpensifyThe text was updated successfully, but these errors were encountered: