[Due for payment 2025-01-18] [$250] Mark the self tour as completed when user returns from Navattic

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation (hyperlinked to channel name):

Action Performed:

Break down in numbered steps

When user completes the Self Tour in Navattic, then the url will newly include ?navattic=completed query param.

Expected Result:

Describe what you think should've happened

When the user returns to Expensify to the ConciergePage with this param, make sure to call the SelfTourViewed API

Actual Result:

Describe what actually happened

Nothing happens now

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876310402323638158
• Upwork Job ID: 1876310402323638158
• Last Price Increase: 2025-01-06

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[mountiny]

@c3024 will implement this change and @rushatgabhane is here for c+ role.

Thanks for picking this us @c3024, what is your ETA for the PR?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021876310402323638158

[melvin-bot]

Current assignees @rushatgabhane and @c3024 are eligible for the External assigner, not assigning anyone new.

[c3024]

@mountiny , raised a PR.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.83-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Mark the tour task as complete on redirecting to Concierge after finishing the Navattic tour #54824

If no regressions arise, payment will be issued on 2025-01-18. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @c3024 requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @c3024] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• Reviewer: @c3024 owed $250 via NewDot

BugZero Checklist (@RachCHopkins)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1876310402323638158/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@rushatgabhane, @RachCHopkins, @mountiny, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[c3024]

Regression test proposal:

1. Login with a new account.
2. Choose any onboarding intent except "Something else".
3. Go to Concierge or #admins room and click on the "Take a 2 minute tour" task.
4. Click on the tour link in the tour description.
5. Complete the Navattic tour.
6. Verify that the tour task is marked as complete on redirect to Concierge after completing the tour.

[RachCHopkins]

Payment Summary:

• Contributor: @c3024 to be paid $250 via NewDot manual request
• Contributor+: @rushatgabhane to be paid $250 via NewDot manual request

Upwork job here

[RachCHopkins]

No payments via Upwork, the contract has been completed, and the Upwork post has been closed.

[JmillsExpensify]

$250 approved for @c3024

[garrettmknight]

$250 approved for @rushatgabhane