[READY for payment 2025-01-07] [HOLD for payment 2025-01-02] Chat- Back button from expense detail leads to LHN rather than expense report conversation

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): testpayment9356yeg0@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung s10/ chrome
App Component: Chat Report View

Action Performed:

1. Navigate to https://staging.new.expensify.com
2. Open any chat
3. Submit an expense
4. Navigate to expense detail page and click the top left back button

Expected Result:

The Back button navigate to expense conversation page

Actual Result:

Back button leads to LHN rather than expense report conversation

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701565_1735002323431.Screen_Recording_20241224_035846_Chrome.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Edited by proposal-police: This proposal was edited at 2024-12-24 07:30:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button leads to LHN rather than expense report conversation

What is the root cause of that problem?

Offending PR: #53969

We are setting to go back to ROUTES.HOME here and go back with shouldPopToTop as true

App/src/pages/home/ReportScreen.tsx

Line 299 in 8b7096f

Navigation.goBack(ROUTES.HOME, false, true);

What changes do you think we should make in order to solve the problem?

We should update route to undefined

 Navigation.goBack(undefined, false, true);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[DylanDylann]

It came from this change

@pac-guerreiro updated it to fix another bug. But now @pac-guerreiro is OOO. I will revert this change only to fix this bug

[daledah]

@RachCHopkins @cristipaval It is currently a deploy blocker that needs immediate attention. The previous PR addressed the issue in debug mode without impacting the production environment, so the fix should be straightforward.
If Dylan were to create the PR, we would need additional time for the C+ request and review process. However, since both @DylanDylann and I are online, I can quickly create a PR within 5 minutes and have @DylanDylann review it right away.

[DylanDylann]

@daledah Thanks for your concern, It seems to make sense. I haven't started on it.

@cristipaval What do you think about it? because @pac-guerreiro (the author of the offending PR) is OOO, @daledah can help to raise a PR because they also take time to investigate and find the RCA. Then we can compensate them a part

[cristipaval]

@daledah, thanks for jumping in! Please go ahead with your solution

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Beamanator]

That ^ was me linking #54508 to this one b/c they look like the same root cause

[daledah]

I'll raise PR soon

[Beamanator]

Fixed in staging so removed blocker label!

I believe we need to pay out @daledah for the fix before closing this out, right?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] fix: go back to LHN page #54511

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment (Needs manual offer from BZ)
• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @RachCHopkins @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[RachCHopkins]

@DylanDylann can you get that checklist organised please?

[DylanDylann]

@RachCHopkins I believe that we don't need a checklist here. Because this issue is a regression from a previous PR

[RachCHopkins]

Payment Summary:

• Contributor: @daledah to be paid $250 via NewDot Manual Request
• Contributor+: @DylanDylann to be paid $250 via NewDot Manual Request

No Upwork job.

@DylanDylann is that actually correct? (Sorry, I missed all the fun here, it assigned to me on Xmas eve about 90 mins before Melvin considered me to me on leave -10:30pm, thanks Melv - and I just got back yesterday)

I'm also about to be on leave for 2 more NZ public holidays.

[DylanDylann]

@RachCHopkins I shouldn't get paid on this issue because it is regression from the previous PR that I already reviewed

[DylanDylann]

Let's pay to @daledah only

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] fix: go back to LHN page #54511

If no regressions arise, payment will be issued on 2025-01-07. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment (Needs manual offer from BZ)
• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @RachCHopkins @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

No need checklist. It is regression bug

[Beamanator]

agreed 👍

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)
• ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@RachCHopkins)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@cristipaval, @RachCHopkins, @DylanDylann, @daledah Huh... This is 4 days overdue. Who can take care of this?

[RachCHopkins]

Sorry team, this was hidden from my view! Will get to this asap!!

[RachCHopkins]

Sorry @daledah I just realised we pay you via Upwork of course! I have just sent you the offer!

[RachCHopkins]

Payment Summary:

• Contributor: @daledah to be paid $250 via Upwork
• Contributor+: @DylanDylann - no payment due to regression

Upwork job here

[RachCHopkins]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.