-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Approval flow - Non-admin approver does not have access to workspace chat with submitter #53937
Comments
Triggered auto assignment to @greg-schroeder ( |
Job added to Upwork: https://www.upwork.com/jobs/~021866909364662980021 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
|
Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue. |
@IuliiaHerets Hi, tried reproducing but there seems to be a bug with adding members to the workspace. One user only sees 2 members in the workspace while the other can see all 3. Screen.Recording.2024-12-12.at.16.41.57.mp4 |
Continue investigation possible root causes |
@IuliiaHerets @greg-schroeder @mollfpr - was not able to reproduce on latest dev env: Screen.Recording.2024-12-16.at.16.46.40.movBased on the code - it seems like issue was fixed with a new way of identify getReport function (#53385) - which was merged not so far ago |
Thanks @narefyev91 - I suppose we close then! |
QA team still can repro the issue in the latest build 20241217_214520.mp4 |
@IuliiaHerets could please QA shared Onyx data? for current report |
@narefyev91 Done |
My findings so far: Logs which we currently have:
Request Response:
{
"accountID": 18853951,
"accounts": {
"18853951": {
"lastUpdateID": 3474643499,
"previousUpdateID": 3474623772,
"updateIDs": [
3474643487,
3474643488,
3474643489,
3474643490,
3474643492,
3474643494,
3474643495,
3474643496,
3474643497,
3474643499
]
}
},
"chatReportID": 4643888930449010,
"createdReportActionIDForThread": 7286133091768299550,
"email": "wisok39037@chosenx.com",
"fetchableOnyxUpdates": [
"3474643487",
"3474643488",
"3474643489",
"3474643490",
"3474643491",
"3474643492",
"3474643493",
"3474643494",
"3474643495",
"3474643496",
"3474643497",
"3474643498",
"3474643499"
],
"lastIOUAction": {
"accountEmail": "wisok39037@chosenx.com",
"accountID": 18853951,
"action": "IOU",
"created": "2024-12-18 12:44:00.071",
"createdAccountIDs": [
},
},
],
},
}, And what Approved gets - after Pusher event happened:
], The most important here - that Approver should get access to chat in which other user will submit expenses: Which means that technically Approver does not know a lot about chat of expenses from other user. Ex. if i just add report info directly in function - Approver will see correct header:
![]() let me know wdyt @greg-schroeder @mollfpr |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@mollfpr could we ask BE engineer to get into this one? |
@mollfpr, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@greg-schroeder Could you add the Internal label? Thank you! |
Will do! |
Triggered auto assignment to @dubielzyk-expensify ( |
Assume I was assigned by mistake with the design label, so I'll unassign, but let me know if you need any visual eyes on it 👍 |
Oops, yes, sorry about that @dubielzyk-expensify |
Awaiting an internal volunteer |
Issue not reproducible during KI retests. (Second week) |
@mollfpr, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick! |
This might have been resolved - not able to reproduce |
Closing as resolved elsewhere; please comment/reopen if you disagree. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.74-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5324457
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
User B (non-admin approver) should have access to workspace chat with User C.
Actual Result:
User B (non-admin approver) does not have access to workspace chat with User C. User B can only access the expense report and not the main chat.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6691007_1733923281004.bandicam_2024-12-11_21-16-43-361.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: