Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Approval flow - Non-admin approver does not have access to workspace chat with submitter #53937

Closed
8 tasks done
IuliiaHerets opened this issue Dec 11, 2024 · 37 comments
Closed
8 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.74-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5324457
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Admin invites User B and C (both are members) to the workspace.
  • Workflows are enabled.
  • Add approvals are enabled.
  • User B is the approver, but not an admin.
  1. Go to staging.new.expensify.com
  2. [User C] Go to workspace chat.
  3. [User C] Submit an expense.
  4. [User B] Open the report as approver.

Expected Result:

User B (non-admin approver) should have access to workspace chat with User C.

Actual Result:

User B (non-admin approver) does not have access to workspace chat with User C. User B can only access the expense report and not the main chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6691007_1733923281004.bandicam_2024-12-11_21-16-43-361.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021866909364662980021
  • Upwork Job ID: 1866909364662980021
  • Last Price Increase: 2025-01-01
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@greg-schroeder greg-schroeder added the External Added to denote the issue can be worked on by a contributor label Dec 11, 2024
@melvin-bot melvin-bot bot changed the title Approval flow - Non-admin approver does not have access to workspace chat with submitter [$250] Approval flow - Non-admin approver does not have access to workspace chat with submitter Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021866909364662980021

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 11, 2024
@greg-schroeder greg-schroeder moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@Sethrollinsbah
Copy link

Contributor details
Your Expensify account email: sethryanrollins@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b495158df32e9c89

Copy link

melvin-bot bot commented Dec 11, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Copy link

melvin-bot bot commented Dec 12, 2024

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@narefyev91
Copy link
Contributor

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

@beodw
Copy link

beodw commented Dec 12, 2024

@IuliiaHerets Hi, tried reproducing but there seems to be a bug with adding members to the workspace. One user only sees 2 members in the workspace while the other can see all 3.

Screen.Recording.2024-12-12.at.16.41.57.mp4

@narefyev91
Copy link
Contributor

Continue investigation possible root causes

@narefyev91
Copy link
Contributor

@IuliiaHerets @greg-schroeder @mollfpr - was not able to reproduce on latest dev env:

Screen.Recording.2024-12-16.at.16.46.40.mov

Based on the code - it seems like issue was fixed with a new way of identify getReport function (#53385) - which was merged not so far ago

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
@greg-schroeder
Copy link
Contributor

Thanks @narefyev91 - I suppose we close then!

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2024
@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Dec 16, 2024
@IuliiaHerets
Copy link
Author

QA team still can repro the issue in the latest build

20241217_214520.mp4

@IuliiaHerets IuliiaHerets reopened this Dec 17, 2024
@narefyev91
Copy link
Contributor

QA team still can repro the issue in the latest build

20241217_214520.mp4

@IuliiaHerets could please QA shared Onyx data? for current report

@IuliiaHerets
Copy link
Author

@narefyev91 Done
1812.txt

@narefyev91
Copy link
Contributor

My findings so far:
Seems like root case here that Approver (not an admin) does not have information about report in Onyx.
Based on the function getParentNavigationSubtitle - we decide to render or not render line with main chat info.
Screenshot 2024-12-18 at 16 49 45

Logs which we currently have:
https://dev.new.expensify.com:8082/api/RequestMoney?
Request Payload:

debtorEmail:
debtorAccountID: 0
amount: 200
currency: EUR
comment:
created: 2024-12-18
merchant: v
iouReportID: 4250766992860460
chatReportID: 4643888930449010
transactionID: 8288794117033059372
reportActionID: 4343434100181137361
createdChatReportActionID: -1
createdIOUReportActionID: -1
reportPreviewReportActionID: 8796743627379055500
taxCode:
taxAmount: 0
billable: false
transactionThreadReportID: 4113251246545677
createdReportActionIDForThread: 7286133091768299550
apiRequestType: write
pusherSocketID: 811412.46757
shouldRetry: true
canCancel: true
referer: ecash
platform: web
api_setCookie: false
email: wisok39037@chosenx.com
isFromDevEnv: true
appversion: 9.0.76-7
clientUpdateID: 3474623772

Request Response:

{ "accountID": 18853951, "accounts": { "18853951": { "lastUpdateID": 3474643499, "previousUpdateID": 3474623772, "updateIDs": [ 3474643487, 3474643488, 3474643489, 3474643490, 3474643492, 3474643494, 3474643495, 3474643496, 3474643497, 3474643499 ] } }, "chatReportID": 4643888930449010, "createdReportActionIDForThread": 7286133091768299550, "email": "wisok39037@chosenx.com", "fetchableOnyxUpdates": [ "3474643487", "3474643488", "3474643489", "3474643490", "3474643491", "3474643492", "3474643493", "3474643494", "3474643495", "3474643496", "3474643497", "3474643498", "3474643499" ], "lastIOUAction": { "accountEmail": "wisok39037@chosenx.com", "accountID": 18853951, "action": "IOU", "created": "2024-12-18 12:44:00.071", "createdAccountIDs": [
],
"mentionedAccountIDs": [
  
],
"mentionedReportIDs": [
  
],
"message": {
  "IOUReportID": 4250766992860460,
  "IOUTransactionID": "8288794117033059372",
  "amount": 200,
  "comment": "",
  "currency": "EUR",
  "isNewDot": true,
  "lastModified": "2024-12-18 12:44:00.071",
  "participantAccountIDs": [
    18853951,
    0
  ],
  "type": "create"
},
"reportActionID": 4343434100181137361,
"reportID": 4250766992860460,
"userMentionedAccountIDs": [
  
]

},
"linkedReportID": 4250766992860460,
"modifiedExpenseReportAction": null,
"moneyRequestReportSummary": {
"currency": "EUR",
"hasParentAccess": true,
"isOwnPolicyExpenseChat": false,
"isPinned": false,
"isPolicyAdmin": false,
"lastActionActorAccountID": 18853951,
"lastActionActorEmail": "wisok39037@chosenx.com",
"lastActionCreated": "2024-12-18 12:44:00.071",
"lastActionLastModified": "2024-12-18 12:44:00.071",
"lastActionMessage": {
"IOUReportID": 4250766992860460,
"IOUTransactionID": "8288794117033059372",
"amount": 200,
"comment": "",
"currency": "EUR",
"isNewDot": true,
"lastModified": "2024-12-18 12:44:00.071",
"participantAccountIDs": [
18853951,
0
],
"type": "create"
},
"lastActionType": "IOU",
"lastReportAction": {
"action": "IOU",
"actorAccountID": 18853951,
"actorEmail": "wisok39037@chosenx.com",
"created": "2024-12-18 12:44:00.071",
"message": "{"IOUReportID":4250766992860460,"IOUTransactionID":"8288794117033059372","amount":200,"comment":"","currency":"EUR","isNewDot":true,"lastModified":"2024-12-18 12:44:00.071","participantAccountIDs":[18853951,0],"type":"create"}",
"reportActionID": 4343434100181137361
},
"managerID": 18853950,
"nonReimbursableTotal": 0,
"ownerAccountID": 18853951,
"ownerEmail": "wisok39037@chosenx.com",
"parentReportAction": {
"accountEmail": "wisok39037@chosenx.com",
"accountID": "18853951",
"action": "REPORTPREVIEW",
"childCanHold": true,
"childCanUnhold": false,
"childCommenterCount": 0,
"childLastActorAccountID": 18853951,
"childLastMoneyRequestComment": "",
"childLastReceiptTransactionIDs": "",
"childLastVisibleActionCreated": "",
"childMoneyRequestCount": 3,
"childOldestFourAccountIDs": "",
"childRecentReceiptTransactionIDs": [

  ],
  "childReportNotificationPreference": "hidden",
  "childType": "expense",
  "childVisibleActionCount": 0,
  "created": "2024-12-18 12:19:29.926",
  "message": {
    "isNewDot": true,
    "lastModified": "2024-12-18 12:19:29.926",
    "linkedReportID": 4250766992860460
  },
  "reportActionID": "8796743627379055500",
  "reportID": 4643888930449010
},
"parentReportID": 4643888930449010,
"participants": {
  "14866370": {
    "notificationPreference": "hidden"
  },
  "18853950": {
    "notificationPreference": "hidden"
  },
  "18853951": {
    "notificationPreference": "hidden"
  }
},
"reportID": 4250766992860460,
"reportName": "Expense Report #4250766992860460",
"reportNameValuePairs": {
  "expensify_policyID": "D8CD48C477D9585C",
  "lastReadTime_18853950": "2024-12-18 12:37:01.261",
  "lastReadTime_18853951": "2024-12-18 12:41:12.559",
  "notificationPreferences": {
    "14866370": "hidden",
    "18853950": "hidden",
    "18853951": "hidden"
  },
  "oldPolicyName": "",
  "parentReportActionID": "8796743627379055500",
  "parentReportID": "4643888930449010",
  "type": "expense"
},
"sharedReportList": [
  {
    "accountID": 14866370,
    "email": "n.arefyev91@gmail.com",
    "permissions": "read, write, share, own"
  },
  {
    "accountID": 18853950,
    "email": "fesaxe2186@kelenson.com",
    "permissions": "read, write"
  }
],
"state": 1,
"status": 1,
"total": -600,
"unheldNonReimbursableTotal": 0,
"unheldTotal": -600

},
"notifiableParticipantAccountIDs": [
14866370,
18853951
],
"onyxData": [
{
"onyxMethod": "set",
"key": "reportNextStep_4250766992860460",
"value": {
"message": [
{
"text": "Waiting for "
},
{
"text": "test test",
"type": "strong",
"tooltipText": "fesaxe2186@kelenson.com (click to copy)",
"clickToCopyText": "fesaxe2186@kelenson.com"
},
{
"text": " to "
},
{
"text": "approve"
},
{
"text": " %expenses."
}
],
"title": "Next Step:",
"requiresUserAction": false,
"type": null,
"showUndoSubmit": false,
"showForMobile": true,
"showForExpense": true,
"nextReceiver": "fesaxe2186@kelenson.com",
"icon": "hourglass"
}
},
{
"key": "report_4250766992860460",
"onyxMethod": "merge",
"value": {
"participants": {
"14866370": {
"notificationPreference": "hidden"
},
"18853950": {
"notificationPreference": "hidden"
},
"18853951": {
"notificationPreference": "hidden"
}
}
}
},
{
"key": "personalDetailsList",
"onyxMethod": "merge",
"value": {
"18853951": {
"accountID": 18853951,
"avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_8.png",
"displayName": "test test",
"firstName": "test",
"lastName": "test",
"login": "wisok39037@chosenx.com",
"phoneNumber": "",
"pronouns": "",
"status": null,
"timezone": {
"automatic": true,
"selected": "Europe/Vilnius"
},
"validated": true
}
}
},
{
"key": "report_4250766992860460",
"onyxMethod": "merge",
"value": {
"chatType": "",
"description": "",
"lastActorAccountID": 18853951,
"lastMessageText": "\u20ac2.00 expense",
"lastVisibleActionCreated": "2024-12-18 12:44:00.071",
"managerID": 18853950,
"ownerAccountID": 18853951,
"parentReportActionID": "8796743627379055500",
"parentReportID": "4643888930449010",
"policyID": "D8CD48C477D9585C",
"reportID": "4250766992860460",
"reportName": "Expense Report #4250766992860460",
"state": "SUBMITTED",
"stateNum": 1,
"statusNum": 1,
"type": "expense",
"visibility": null
}
},
{
"key": "reportActions_4250766992860460",
"onyxMethod": "merge",
"shouldShowPushNotification": true,
"value": {
"4343434100181137361": {
"actionName": "IOU",
"actorAccountID": 18853951,
"avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_8.png",
"created": "2024-12-18 12:44:00.071",
"lastModified": "2024-12-18 12:44:00.071",
"message": [
{
"html": "\u20ac2.00 expense",
"text": "\u20ac2.00 expense",
"type": "COMMENT",
"whisperedTo": [

          ]
        }
      ],
      "originalMessage": {
        "IOUReportID": 4250766992860460,
        "IOUTransactionID": "8288794117033059372",
        "amount": 200,
        "comment": "",
        "currency": "EUR",
        "isNewDot": true,
        "lastModified": "2024-12-18 12:44:00.071",
        "participantAccountIDs": [
          18853951,
          0
        ],
        "type": "create"
      },
      "person": [
        {
          "style": "strong",
          "text": "test test",
          "type": "TEXT"
        }
      ],
      "reportActionID": "4343434100181137361",
      "shouldShow": true
    }
  }
},
{
  "key": "reportActions_4643888930449010",
  "onyxMethod": "merge",
  "value": {
    "8796743627379055500": {
      "actionName": "REPORTPREVIEW",
      "actorAccountID": 18853951,
      "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_8.png",
      "childCanHold": true,
      "childCanUnhold": false,
      "childCommenterCount": 0,
      "childLastActorAccountID": 18853951,
      "childLastMoneyRequestComment": "",
      "childLastReceiptTransactionIDs": "",
      "childLastVisibleActionCreated": "",
      "childManagerAccountID": 18853950,
      "childMoneyRequestCount": 3,
      "childOldestFourAccountIDs": "",
      "childOwnerAccountID": 18853951,
      "childRecentReceiptTransactionIDs": [
        
      ],
      "childReportID": 4250766992860460,
      "childReportName": "Expense Report #4250766992860460",
      "childReportNotificationPreference": "hidden",
      "childStateNum": 1,
      "childStatusNum": 1,
      "childType": "expense",
      "childVisibleActionCount": 0,
      "created": "2024-12-18 12:19:29.926",
      "lastModified": "2024-12-18 12:19:29.926",
      "message": [
        {
          "html": "Testing12349 Accountrerer's Workspace 16 owes \u20ac4.00",
          "text": "Testing12349 Accountrerer's Workspace 16 owes \u20ac4.00",
          "type": "COMMENT",
          "whisperedTo": [
            
          ]
        }
      ],
      "originalMessage": {
        "isNewDot": true,
        "lastModified": "2024-12-18 12:19:29.926",
        "linkedReportID": "4250766992860460"
      },
      "person": [
        {
          "style": "strong",
          "text": "test test",
          "type": "TEXT"
        }
      ],
      "reportActionID": "8796743627379055500",
      "shouldShow": true
    }
  }
},
{
  "key": "report_4113251246545677",
  "onyxMethod": "merge",
  "value": {
    "participants": {
      "14866370": {
        "notificationPreference": "hidden"
      }
    }
  }
},
{
  "key": "report_4113251246545677",
  "onyxMethod": "merge",
  "value": {
    "participants": {
      "18853950": {
        "notificationPreference": "hidden"
      }
    }
  }
},
{
  "key": "report_4113251246545677",
  "onyxMethod": "merge",
  "value": {
    "participants": {
      "18853951": {
        "notificationPreference": "hidden"
      }
    }
  }
},
{
  "key": "reportActions_4250766992860460",
  "onyxMethod": "merge",
  "value": {
    "4343434100181137361": {
      "childReportNotificationPreference": "hidden"
    }
  }
},
{
  "key": "reportActions_4643888930449010",
  "onyxMethod": "merge",
  "value": {
    "8796743627379055500": {
      "childCanHold": true,
      "childCanUnhold": false,
      "childCommenterCount": 0,
      "childLastActorAccountID": 18853951,
      "childLastMoneyRequestComment": "",
      "childLastReceiptTransactionIDs": "",
      "childLastVisibleActionCreated": "",
      "childManagerAccountID": 18853950,
      "childMoneyRequestCount": 3,
      "childOldestFourAccountIDs": "",
      "childOwnerAccountID": 18853951,
      "childRecentReceiptTransactionIDs": [
        
      ],
      "childReportID": 4250766992860460,
      "childReportName": "Expense Report #4250766992860460",
      "childReportNotificationPreference": "hidden",
      "childStateNum": 1,
      "childStatusNum": 1,
      "childType": "expense",
      "childVisibleActionCount": 0,
      "message": [
        {
          "html": "Testing12349 Accountrerer's Workspace 16 owes \u20ac6.00",
          "text": "Testing12349 Accountrerer's Workspace 16 owes \u20ac6.00",
          "type": "COMMENT",
          "whisperedTo": [
            
          ]
        }
      ],
      "originalMessage": {
        "isNewDot": true,
        "lastModified": "2024-12-18 12:19:29.926",
        "linkedReportID": "4250766992860460"
      }
    }
  }
},
{
  "key": "transactions_8288794117033059372",
  "onyxMethod": "merge",
  "value": {
    "amount": -200,
    "bank": "",
    "billable": false,
    "cardID": 0,
    "cardName": "Cash Expense",
    "cardNumber": "",
    "category": "",
    "comment": {
      "comment": ""
    },
    "created": "2024-12-18",
    "currency": "EUR",
    "filename": "",
    "hasEReceipt": false,
    "inserted": "2024-12-18 12:44:00",
    "managedCard": false,
    "mcc": "",
    "merchant": "v",
    "modifiedAmount": 0,
    "modifiedCreated": "",
    "modifiedCurrency": "",
    "modifiedMCC": "",
    "modifiedMerchant": "",
    "originalAmount": 0,
    "originalCurrency": "",
    "parentTransactionID": "",
    "posted": "",
    "receipt": {
      
    },
    "reimbursable": true,
    "reportID": "4250766992860460",
    "status": "Posted",
    "tag": "",
    "transactionID": "8288794117033059372"
  }
},
{
  "key": "report_4250766992860460",
  "onyxMethod": "merge",
  "value": {
    "avatarUrl": null,
    "chatReportID": "4643888930449010",
    "chatType": "",
    "currency": "EUR",
    "description": "",
    "errorFields": {
      "export": null,
      "notFound": null
    },
    "fieldList": null,
    "hasOutstandingChildRequest": false,
    "hasOutstandingChildTask": false,
    "hasParentAccess": true,
    "invoiceReceiver": null,
    "iouReportID": null,
    "isCancelledIOU": false,
    "isDeletedParentAction": null,
    "isOwnPolicyExpenseChat": false,
    "isPinned": false,
    "isWaitingOnBankAccount": false,
    "lastActionType": "IOU",
    "lastActorAccountID": "18853951",
    "lastMentionedTime": null,
    "lastMessageHtml": "\u20ac2.00 expense",
    "lastMessageText": "\u20ac2.00 expense",
    "lastReadSequenceNumber": 0,
    "lastReadTime": "2024-12-18 12:41:12.559",
    "lastVisibleActionCreated": "2024-12-18 12:44:00.071",
    "lastVisibleActionLastModified": "2024-12-18 12:44:00.071",
    "managerID": 18853950,
    "nonReimbursableTotal": 0,
    "oldPolicyName": "",
    "ownerAccountID": 18853951,
    "parentReportActionID": "8796743627379055500",
    "parentReportID": "4643888930449010",
    "participants": {
      "14866370": {
        "notificationPreference": "hidden"
      },
      "18853950": {
        "notificationPreference": "hidden"
      },
      "18853951": {
        "notificationPreference": "hidden"
      }
    },
    "permissions": [
      
    ],
    "policyAvatar": null,
    "policyID": "D8CD48C477D9585C",
    "policyName": null,
    "private_isArchived": "",
    "reportID": "4250766992860460",
    "reportName": "Expense Report #4250766992860460",
    "stateNum": 1,
    "statusNum": 1,
    "total": -600,
    "tripData": null,
    "type": "expense",
    "unheldNonReimbursableTotal": 0,
    "unheldTotal": -600,
    "visibility": null,
    "welcomeMessage": "",
    "writeCapability": "all"
  }
},
{
  "key": "reportNameValuePairs_4250766992860460",
  "onyxMethod": "merge",
  "value": {
    "type": "expense"
  }
},
{
  "key": "report_4643888930449010",
  "onyxMethod": "merge",
  "value": {
    "hasOutstandingChildRequest": false
  }
},
{
  "key": "reportActions_4643888930449010",
  "onyxMethod": "merge",
  "value": {
    "8796743627379055500": {
      "childCanHold": true,
      "childCanUnhold": false,
      "childCommenterCount": 0,
      "childLastActorAccountID": 18853951,
      "childLastMoneyRequestComment": "",
      "childLastReceiptTransactionIDs": "",
      "childLastVisibleActionCreated": "",
      "childManagerAccountID": 18853950,
      "childMoneyRequestCount": 3,
      "childOldestFourAccountIDs": "",
      "childOwnerAccountID": 18853951,
      "childRecentReceiptTransactionIDs": [
        
      ],
      "childReportID": 4250766992860460,
      "childReportName": "Expense Report #4250766992860460",
      "childReportNotificationPreference": "hidden",
      "childStateNum": 1,
      "childStatusNum": 1,
      "childType": "expense",
      "childVisibleActionCount": 0,
      "message": [
        {
          "html": "Testing12349 Accountrerer's Workspace 16 owes \u20ac6.00",
          "text": "Testing12349 Accountrerer's Workspace 16 owes \u20ac6.00",
          "type": "COMMENT",
          "whisperedTo": [
            
          ]
        }
      ],
      "originalMessage": {
        "isNewDot": true,
        "lastModified": "2024-12-18 12:19:29.926",
        "linkedReportID": "4250766992860460"
      }
    }
  }
},
{
  "key": "reportActions_4643888930449010",
  "onyxMethod": "merge",
  "value": {
    "8796743627379055500": {
      "childMoneyRequestCount": 3,
      "reportActionID": "8796743627379055500"
    }
  }
},
{
  "key": "report_4250766992860460",
  "onyxMethod": "merge",
  "value": {
    "chatType": "",
    "lastActorAccountID": 18853951,
    "lastMessageText": "",
    "lastVisibleActionCreated": "2024-12-18 12:44:00.071",
    "managerID": 18853950,
    "nonReimbursableTotal": 0,
    "ownerAccountID": 18853951,
    "parentReportActionID": "8796743627379055500",
    "parentReportID": "4643888930449010",
    "policyID": "D8CD48C477D9585C",
    "reportID": "4250766992860460",
    "reportName": "Expense Report #4250766992860460",
    "stateNum": 1,
    "statusNum": 1,
    "total": "-600",
    "type": "expense",
    "visibility": null
  }
},
{
  "key": "userMetadata",
  "onyxMethod": "set",
  "value": {
    "accountID": 18853951,
    "email": "wisok39037@chosenx.com",
    "freeTrial": false,
    "planType": "team",
    "role": "user",
    "tryNewDotDismissed": false
  }
},
{
  "key": "transactionViolations_",
  "onyxMethod": "mergecollection",
  "value": {
    "transactionViolations_3552749667029766235": [
      {
        "data": {
          "duplicates": [
            "6823978597839781364",
            "8288794117033059372"
          ],
          "tooltip": "List the potential duplicate transactions and merge, delete, or ignore them."
        },
        "name": "duplicatedTransaction",
        "showInReview": true,
        "type": "warning"
      }
    ],
    "transactionViolations_6823978597839781364": [
      {
        "data": {
          "duplicates": [
            "3552749667029766235",
            "8288794117033059372"
          ],
          "tooltip": "List the potential duplicate transactions and merge, delete, or ignore them."
        },
        "name": "duplicatedTransaction",
        "showInReview": true,
        "type": "warning"
      }
    ],
    "transactionViolations_8288794117033059372": [
      {
        "data": {
          "duplicates": [
            "3552749667029766235",
            "6823978597839781364"
          ],
          "tooltip": "List the potential duplicate transactions and merge, delete, or ignore them."
        },
        "name": "duplicatedTransaction",
        "showInReview": true,
        "type": "warning"
      }
    ]
  }
}

],
"onyxUpdates": {
"3474643487": [
{
"key": "report_4250766992860460",
"onyxMethod": "merge",
"value": {
"participants": {
"14866370": {
"notificationPreference": "hidden"
},
"18853950": {
"notificationPreference": "hidden"
},
"18853951": {
"notificationPreference": "hidden"
}
}
}
},
{
"key": "personalDetailsList",
"onyxMethod": "merge",
"value": {
"18853951": {
"accountID": 18853951,
"avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_8.png",
"displayName": "test test",
"firstName": "test",
"lastName": "test",
"login": "wisok39037@chosenx.com",
"phoneNumber": "",
"pronouns": "",
"status": null,
"timezone": {
"automatic": true,
"selected": "Europe/Vilnius"
},
"validated": true
}
}
}
],
"3474643488": [
{
"key": "report_4250766992860460",
"onyxMethod": "merge",
"value": {
"chatType": "",
"description": "",
"lastActorAccountID": 18853951,
"lastMessageText": "\u20ac2.00 expense",
"lastVisibleActionCreated": "2024-12-18 12:44:00.071",
"managerID": 18853950,
"ownerAccountID": 18853951,
"parentReportActionID": "8796743627379055500",
"parentReportID": "4643888930449010",
"policyID": "D8CD48C477D9585C",
"reportID": "4250766992860460",
"reportName": "Expense Report #4250766992860460",
"state": "SUBMITTED",
"stateNum": 1,
"statusNum": 1,
"type": "expense",
"visibility": null
}
},
{
"key": "reportActions_4250766992860460",
"onyxMethod": "merge",
"shouldShowPushNotification": true,
"value": {
"4343434100181137361": {
"actionName": "IOU",
"actorAccountID": 18853951,
"avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_8.png",
"created": "2024-12-18 12:44:00.071",
"lastModified": "2024-12-18 12:44:00.071",
"message": [
{
"html": "\u20ac2.00 expense",
"text": "\u20ac2.00 expense",
"type": "COMMENT",
"whisperedTo": [

            ]
          }
        ],
        "originalMessage": {
          "IOUReportID": 4250766992860460,
          "IOUTransactionID": "8288794117033059372",
          "amount": 200,
          "comment": "",
          "currency": "EUR",
          "isNewDot": true,
          "lastModified": "2024-12-18 12:44:00.071",
          "participantAccountIDs": [
            18853951,
            0
          ],
          "type": "create"
        },
        "person": [
          {
            "style": "strong",
            "text": "test test",
            "type": "TEXT"
          }
        ],
        "reportActionID": "4343434100181137361",
        "shouldShow": true
      }
    }
  }
],
"3474643489": [
  {
    "key": "reportActions_4643888930449010",
    "onyxMethod": "merge",
    "value": {
      "8796743627379055500": {
        "actionName": "REPORTPREVIEW",
        "actorAccountID": 18853951,
        "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_8.png",
        "childCanHold": true,
        "childCanUnhold": false,
        "childCommenterCount": 0,
        "childLastActorAccountID": 18853951,
        "childLastMoneyRequestComment": "",
        "childLastReceiptTransactionIDs": "",
        "childLastVisibleActionCreated": "",
        "childManagerAccountID": 18853950,
        "childMoneyRequestCount": 3,
        "childOldestFourAccountIDs": "",
        "childOwnerAccountID": 18853951,
        "childRecentReceiptTransactionIDs": [
          
        ],
        "childReportID": 4250766992860460,
        "childReportName": "Expense Report #4250766992860460",
        "childReportNotificationPreference": "hidden",
        "childStateNum": 1,
        "childStatusNum": 1,
        "childType": "expense",
        "childVisibleActionCount": 0,
        "created": "2024-12-18 12:19:29.926",
        "lastModified": "2024-12-18 12:19:29.926",
        "message": [
          {
            "html": "Testing12349 Accountrerer's Workspace 16 owes \u20ac4.00",
            "text": "Testing12349 Accountrerer's Workspace 16 owes \u20ac4.00",
            "type": "COMMENT",
            "whisperedTo": [
              
            ]
          }
        ],
        "originalMessage": {
          "isNewDot": true,
          "lastModified": "2024-12-18 12:19:29.926",
          "linkedReportID": "4250766992860460"
        },
        "person": [
          {
            "style": "strong",
            "text": "test test",
            "type": "TEXT"
          }
        ],
        "reportActionID": "8796743627379055500",
        "shouldShow": true
      }
    }
  }
],
"3474643490": [
  {
    "key": "report_4113251246545677",
    "onyxMethod": "merge",
    "value": {
      "participants": {
        "14866370": {
          "notificationPreference": "hidden"
        }
      }
    }
  }
],
"3474643492": [
  {
    "key": "report_4113251246545677",
    "onyxMethod": "merge",
    "value": {
      "participants": {
        "18853950": {
          "notificationPreference": "hidden"
        }
      }
    }
  }
],
"3474643494": [
  {
    "key": "report_4113251246545677",
    "onyxMethod": "merge",
    "value": {
      "participants": {
        "18853951": {
          "notificationPreference": "hidden"
        }
      }
    }
  }
],
"3474643495": [
  {
    "key": "reportActions_4250766992860460",
    "onyxMethod": "merge",
    "value": {
      "4343434100181137361": {
        "childReportNotificationPreference": "hidden"
      }
    }
  }
],
"3474643496": [
  {
    "key": "reportActions_4643888930449010",
    "onyxMethod": "merge",
    "value": {
      "8796743627379055500": {
        "childCanHold": true,
        "childCanUnhold": false,
        "childCommenterCount": 0,
        "childLastActorAccountID": 18853951,
        "childLastMoneyRequestComment": "",
        "childLastReceiptTransactionIDs": "",
        "childLastVisibleActionCreated": "",
        "childManagerAccountID": 18853950,
        "childMoneyRequestCount": 3,
        "childOldestFourAccountIDs": "",
        "childOwnerAccountID": 18853951,
        "childRecentReceiptTransactionIDs": [
          
        ],
        "childReportID": 4250766992860460,
        "childReportName": "Expense Report #4250766992860460",
        "childReportNotificationPreference": "hidden",
        "childStateNum": 1,
        "childStatusNum": 1,
        "childType": "expense",
        "childVisibleActionCount": 0,
        "message": [
          {
            "html": "Testing12349 Accountrerer's Workspace 16 owes \u20ac6.00",
            "text": "Testing12349 Accountrerer's Workspace 16 owes \u20ac6.00",
            "type": "COMMENT",
            "whisperedTo": [
              
            ]
          }
        ],
        "originalMessage": {
          "isNewDot": true,
          "lastModified": "2024-12-18 12:19:29.926",
          "linkedReportID": "4250766992860460"
        }
      }
    }
  }
],
"3474643497": [
  {
    "key": "transactions_8288794117033059372",
    "onyxMethod": "merge",
    "value": {
      "amount": -200,
      "bank": "",
      "billable": false,
      "cardID": 0,
      "cardName": "Cash Expense",
      "cardNumber": "",
      "category": "",
      "comment": {
        "comment": ""
      },
      "created": "2024-12-18",
      "currency": "EUR",
      "filename": "",
      "hasEReceipt": false,
      "inserted": "2024-12-18 12:44:00",
      "managedCard": false,
      "mcc": "",
      "merchant": "v",
      "modifiedAmount": 0,
      "modifiedCreated": "",
      "modifiedCurrency": "",
      "modifiedMCC": "",
      "modifiedMerchant": "",
      "originalAmount": 0,
      "originalCurrency": "",
      "parentTransactionID": "",
      "posted": "",
      "receipt": [
        
      ],
      "reimbursable": true,
      "reportID": "4250766992860460",
      "status": "Posted",
      "tag": "",
      "transactionID": "8288794117033059372"
    }
  },
  {
    "key": "report_4250766992860460",
    "onyxMethod": "merge",
    "value": {
      "avatarUrl": null,
      "chatReportID": "4643888930449010",
      "chatType": "",
      "currency": "EUR",
      "description": "",
      "errorFields": {
        "export": null,
        "notFound": null
      },
      "fieldList": null,
      "hasOutstandingChildRequest": false,
      "hasOutstandingChildTask": false,
      "hasParentAccess": true,
      "invoiceReceiver": null,
      "iouReportID": null,
      "isCancelledIOU": false,
      "isDeletedParentAction": null,
      "isOwnPolicyExpenseChat": false,
      "isPinned": false,
      "isWaitingOnBankAccount": false,
      "lastActionType": "IOU",
      "lastActorAccountID": "18853951",
      "lastMentionedTime": null,
      "lastMessageHtml": "\u20ac2.00 expense",
      "lastMessageText": "\u20ac2.00 expense",
      "lastReadSequenceNumber": 0,
      "lastReadTime": "2024-12-18 12:41:12.559",
      "lastVisibleActionCreated": "2024-12-18 12:44:00.071",
      "lastVisibleActionLastModified": "2024-12-18 12:44:00.071",
      "managerID": 18853950,
      "nonReimbursableTotal": 0,
      "oldPolicyName": "",
      "ownerAccountID": 18853951,
      "parentReportActionID": "8796743627379055500",
      "parentReportID": "4643888930449010",
      "participants": {
        "14866370": {
          "notificationPreference": "hidden"
        },
        "18853950": {
          "notificationPreference": "hidden"
        },
        "18853951": {
          "notificationPreference": "hidden"
        }
      },
      "permissions": [
        
      ],
      "policyAvatar": null,
      "policyID": "D8CD48C477D9585C",
      "policyName": null,
      "private_isArchived": "",
      "reportID": "4250766992860460",
      "reportName": "Expense Report #4250766992860460",
      "stateNum": 1,
      "statusNum": 1,
      "total": -600,
      "tripData": null,
      "type": "expense",
      "unheldNonReimbursableTotal": 0,
      "unheldTotal": -600,
      "visibility": null,
      "welcomeMessage": "",
      "writeCapability": "all"
    }
  },
  {
    "key": "reportNameValuePairs_4250766992860460",
    "onyxMethod": "merge",
    "value": {
      "type": "expense"
    }
  }
],
"3474643499": [
  {
    "key": "report_4643888930449010",
    "onyxMethod": "merge",
    "value": {
      "hasOutstandingChildRequest": false
    }
  }
]

},
"policyID": "D8CD48C477D9585C",
"reportID": 4250766992860460,
"transaction": {
"amount": -200,
"bank": "",
"billable": false,
"cardID": 0,
"cardName": "Cash Expense",
"cardNumber": "",
"category": "",
"comment": {
"comment": ""
},
"created": "2024-12-18",
"currency": "EUR",
"externalID": "",
"filename": "",
"inserted": "2024-12-18 12:44:00",
"managedCard": false,
"mcc": "",
"merchant": "v",
"modifiedAmount": 0,
"modifiedCreated": "",
"modifiedCurrency": "",
"modifiedMCC": "",
"modifiedMerchant": "",
"originalAmount": 0,
"originalCurrency": "",
"parentTransactionID": "",
"posted": "",
"receipt": [

],
"reimbursable": true,
"reportID": "4250766992860460",
"status": "Posted",
"tag": "",
"transactionID": "8288794117033059372"

},
"transactionID": "8288794117033059372",
"transactionThreadReportID": 4113251246545677,
"httpCode": 200,
"jsonCode": 200,
"authResponseMessage": "200 OK",
"requestID": "8f3f3de38a7cb804-RIX",
"previousUpdateID": 3474623772,
"lastUpdateID": 3474643501
}

And what Approved gets - after Pusher event happened:

[
Debug
][
info
][
Report
]HandledmultipleEventseventsentbyPusher-{
"updates": [
{
"data": [
{
"key": "report_4250766992860460",
"onyxMethod": "merge",
"value": {
"participants": {
"14866370": {
"notificationPreference": "hidden"
},
"18853950": {
"notificationPreference": "hidden"
},
"18853951": {
"notificationPreference": "hidden"
}
}
}
},
{
"key": "personalDetailsList",
"onyxMethod": "merge",
"value": {
"18853951": {
"accountID": 18853951,
"avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_8.png",
"displayName": "test test",
"firstName": "test",
"lastName": "test",
"login": "wisok39037@chosenx.com",
"phoneNumber": "",
"pronouns": "",
"status": null,
"timezone": {
"automatic": true,
"selected": "Europe/Vilnius"
},
"validated": true
}
}
},
{
"key": "report_4250766992860460",
"onyxMethod": "merge",
"value": {
"chatType": "",
"description": "",
"lastActorAccountID": 18853951,
"lastMessageText": "€5.00 expense",
"lastVisibleActionCreated": "2024-12-18 12:55:26.272",
"managerID": 18853950,
"ownerAccountID": 18853951,
"parentReportActionID": "8796743627379055500",
"parentReportID": "4643888930449010",
"policyID": "D8CD48C477D9585C",
"reportID": "4250766992860460",
"reportName": "Expense Report #4250766992860460",
"state": "SUBMITTED",
"stateNum": 1,
"statusNum": 1,
"type": "expense",
"visibility": null
}
},
{
"key": "reportActions_4250766992860460",
"onyxMethod": "merge",
"shouldShowPushNotification": true,
"value": {
"7209180545609736895": {
"actionName": "IOU",
"actorAccountID": 18853951,
"avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_8.png",
"created": "2024-12-18 12:55:26.272",
"lastModified": "2024-12-18 12:55:26.272",
"message": [
{
"html": "€5.00 expense",
"text": "€5.00 expense",
"type": "COMMENT",
"whisperedTo": [

              ]
            }
          ],
          "originalMessage": {
            "IOUReportID": 4250766992860460,
            "IOUTransactionID": "6806258711861478333",
            "amount": 500,
            "comment": "",
            "currency": "EUR",
            "isNewDot": true,
            "lastModified": "2024-12-18 12:55:26.272",
            "participantAccountIDs": [
              18853951,
              0
            ],
            "type": "create"
          },
          "person": [
            {
              "style": "strong",
              "text": "test test",
              "type": "TEXT"
            }
          ],
          "reportActionID": "7209180545609736895",
          "shouldShow": true
        }
      }
    },
    {
      "key": "report_4360292578211953",
      "onyxMethod": "merge",
      "value": {
        "participants": {
          "14866370": {
            "notificationPreference": "hidden"
          }
        }
      }
    },
    {
      "key": "report_4360292578211953",
      "onyxMethod": "merge",
      "value": {
        "participants": {
          "18853950": {
            "notificationPreference": "hidden"
          }
        }
      }
    },
    {
      "key": "reportActions_4250766992860460",
      "onyxMethod": "merge",
      "value": {
        "7209180545609736895": {
          "childReportNotificationPreference": "hidden"
        }
      }
    },
    {
      "key": "report_4360292578211953",
      "onyxMethod": "merge",
      "value": {
        "participants": {
          "18853951": {
            "notificationPreference": "hidden"
          }
        }
      }
    },
    {
      "key": "transactions_6806258711861478333",
      "onyxMethod": "merge",
      "value": {
        "amount": -500,
        "bank": "",
        "billable": false,
        "cardID": 0,
        "cardName": "Cash Expense",
        "cardNumber": "",
        "category": "",
        "comment": {
          "comment": ""
        },
        "created": "2024-12-18",
        "currency": "EUR",
        "filename": "",
        "hasEReceipt": false,
        "inserted": "2024-12-18 12:55:26",
        "managedCard": false,
        "mcc": "",
        "merchant": "2",
        "modifiedAmount": 0,
        "modifiedCreated": "",
        "modifiedCurrency": "",
        "modifiedMCC": "",
        "modifiedMerchant": "",
        "originalAmount": 0,
        "originalCurrency": "",
        "parentTransactionID": "",
        "posted": "",
        "receipt": {
          
        },
        "reimbursable": true,
        "reportID": "4250766992860460",
        "status": "Posted",
        "tag": "",
        "transactionID": "6806258711861478333"
      }
    },
    {
      "key": "report_4250766992860460",
      "onyxMethod": "merge",
      "value": {
        "avatarUrl": null,
        "chatReportID": "4643888930449010",
        "chatType": "",
        "currency": "EUR",
        "description": "",
        "errorFields": {
          "export": null,
          "notFound": null
        },
        "fieldList": null,
        "hasOutstandingChildRequest": false,
        "hasOutstandingChildTask": false,
        "hasParentAccess": true,
        "invoiceReceiver": null,
        "iouReportID": null,
        "isCancelledIOU": false,
        "isDeletedParentAction": null,
        "isOwnPolicyExpenseChat": false,
        "isPinned": false,
        "isWaitingOnBankAccount": false,
        "lastActionType": "IOU",
        "lastActorAccountID": "18853951",
        "lastMentionedTime": null,
        "lastMessageHtml": "€5.00 expense",
        "lastMessageText": "€5.00 expense",
        "lastReadSequenceNumber": 0,
        "lastReadTime": "2024-12-18 12:44:00.720",
        "lastVisibleActionCreated": "2024-12-18 12:55:26.272",
        "lastVisibleActionLastModified": "2024-12-18 12:55:26.272",
        "managerID": 18853950,
        "nonReimbursableTotal": 0,
        "oldPolicyName": "",
        "ownerAccountID": 18853951,
        "parentReportActionID": "8796743627379055500",
        "parentReportID": "4643888930449010",
        "participants": {
          "14866370": {
            "notificationPreference": "hidden"
          },
          "18853950": {
            "notificationPreference": "hidden"
          },
          "18853951": {
            "notificationPreference": "hidden"
          }
        },
        "permissions": [
          
        ],
        "policyAvatar": null,
        "policyID": "D8CD48C477D9585C",
        "policyName": null,
        "private_isArchived": "",
        "reportID": "4250766992860460",
        "reportName": "Expense Report #4250766992860460",
        "stateNum": 1,
        "statusNum": 1,
        "total": -1600,
        "tripData": null,
        "type": "expense",
        "unheldNonReimbursableTotal": 0,
        "unheldTotal": -1600,
        "visibility": null,
        "welcomeMessage": "",
        "writeCapability": "all"
      }
    },
    {
      "key": "reportNameValuePairs_4250766992860460",
      "onyxMethod": "merge",
      "value": {
        "type": "expense"
      }
    },
    {
      "key": "report_4643888930449010",
      "onyxMethod": "merge",
      "value": {
        "hasOutstandingChildRequest": true
      }
    },
    {
      "key": "transactionViolations_",
      "onyxMethod": "mergecollection",
      "value": {
        "transactionViolations_3552749667029766235": [
          {
            "data": {
              "duplicates": [
                "6823978597839781364",
                "8288794117033059372"
              ],
              "tooltip": "List the potential duplicate transactions and merge, delete, or ignore them."
            },
            "name": "duplicatedTransaction",
            "showInReview": true,
            "type": "warning"
          }
        ],
        "transactionViolations_6806258711861478333": [
          {
            "data": {
              "duplicates": [
                "7944200864157486836"
              ],
              "tooltip": "List the potential duplicate transactions and merge, delete, or ignore them."
            },
            "name": "duplicatedTransaction",
            "showInReview": true,
            "type": "warning"
          }
        ],
        "transactionViolations_6823978597839781364": [
          {
            "data": {
              "duplicates": [
                "3552749667029766235",
                "8288794117033059372"
              ],
              "tooltip": "List the potential duplicate transactions and merge, delete, or ignore them."
            },
            "name": "duplicatedTransaction",
            "showInReview": true,
            "type": "warning"
          }
        ],
        "transactionViolations_7944200864157486836": [
          {
            "data": {
              "duplicates": [
                "6806258711861478333"
              ],
              "tooltip": "List the potential duplicate transactions and merge, delete, or ignore them."
            },
            "name": "duplicatedTransaction",
            "showInReview": true,
            "type": "warning"
          }
        ],
        "transactionViolations_8288794117033059372": [
          {
            "data": {
              "duplicates": [
                "3552749667029766235",
                "6823978597839781364"
              ],
              "tooltip": "List the potential duplicate transactions and merge, delete, or ignore them."
            },
            "name": "duplicatedTransaction",
            "showInReview": true,
            "type": "warning"
          }
        ]
      }
    }
  ],
  "eventType": "onyxApiUpdate"
}

],
"lastUpdateID": 3474710543,
"previousUpdateID": 3474700192
}–""

The most important here - that Approver should get access to chat in which other user will submit expenses:
Screenshot 2024-12-18 at 17 00 16
In our case id is 4643888930449010
If we check what we have in pusher for Approver - the only info will be:
{ "key": "report_4643888930449010", "onyxMethod": "merge", "value": { "hasOutstandingChildRequest": true } },

Which means that technically Approver does not know a lot about chat of expenses from other user.
Seems like we need to get here some one from BE team - to check - why we do not send information about report chat for Approver.

Ex. if i just add report info directly in function - Approver will see correct header:

const parentReport = {"chatType":"policyExpenseChat","currency":"USD","description":"","errorFields":{},"hasOutstandingChildRequest":false,"hasOutstandingChildTask":false,"iouReportID":"4250766992860460","isCancelledIOU":false,"isOwnPolicyExpenseChat":true,"isPinned":true,"isWaitingOnBankAccount":false,"lastActionType":"REPORTPREVIEW","lastActorAccountID":"18853951","lastMessageHtml":"Testing12349 Accountrerer's Workspace 16 owes €16.00","lastMessageText":"Testing12349 Accountrerer's Workspace 16 owes €16.00","lastReadSequenceNumber":0,"lastReadTime":"2024-12-18 12:35:57.070","lastVisibleActionCreated":"2024-12-18 12:19:29.926","lastVisibleActionLastModified":"2024-12-18 12:19:29.926","managerID":0,"nonReimbursableTotal":0,"oldPolicyName":"","ownerAccountID":18853951,"participants":{"14866370":{"notificationPreference":"always"},"18853951":{"notificationPreference":"always"}},"permissions":[],"policyAvatar":"","policyID":"D8CD48C477D9585C","policyName":"Testing12349 Accountrerer's Workspace 16","private_isArchived":"","reportID":"4643888930449010","reportName":"Chat Report","stateNum":0,"statusNum":0,"total":0,"type":"chat","unheldNonReimbursableTotal":0,"unheldTotal":0,"welcomeMessage":"","writeCapability":"all","lastMessageTranslationKey":""}
Screenshot 2024-12-18 at 17 07 15

let me know wdyt @greg-schroeder @mollfpr

Copy link

melvin-bot bot commented Dec 18, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@narefyev91
Copy link
Contributor

@mollfpr could we ask BE engineer to get into this one?

Copy link

melvin-bot bot commented Jan 3, 2025

@mollfpr, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mollfpr
Copy link
Contributor

mollfpr commented Jan 6, 2025

@greg-schroeder Could you add the Internal label? Thank you!

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2025
@greg-schroeder
Copy link
Contributor

Will do!

@greg-schroeder greg-schroeder added Internal Requires API changes or must be handled by Expensify staff Hot Pick Ready for an engineer to pick up and run with and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 6, 2025
@greg-schroeder greg-schroeder moved this from Done to Bugs and Follow Up Issues in [#whatsnext] #expense Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

@dubielzyk-expensify
Copy link
Contributor

Assume I was assigned by mistake with the design label, so I'll unassign, but let me know if you need any visual eyes on it 👍

@dubielzyk-expensify dubielzyk-expensify removed their assignment Jan 7, 2025
@greg-schroeder
Copy link
Contributor

Oops, yes, sorry about that @dubielzyk-expensify

@melvin-bot melvin-bot bot added the Overdue label Jan 9, 2025
@greg-schroeder
Copy link
Contributor

Awaiting an internal volunteer

@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2025
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Jan 12, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

@mollfpr, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

@greg-schroeder
Copy link
Contributor

This might have been resolved - not able to reproduce

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 13, 2025
@greg-schroeder
Copy link
Contributor

Closing as resolved elsewhere; please comment/reopen if you disagree.

@melvin-bot melvin-bot bot removed the Overdue label Jan 16, 2025
@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff
Projects
Status: Done
Development

No branches or pull requests

8 participants