Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-02] [$250] iOS - Search - Search page briefly goes blank when switching workspace filter #53359

Closed
2 of 8 tasks
IuliiaHerets opened this issue Dec 1, 2024 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+232803@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to Search.
  3. Open workspace switcher.
  4. Select another workspace (create a workspace first if there isn't any).
  5. Open workspace switcher.
  6. Tap Clear filter.

Expected Result:

Search page will not go blank when switching workspace filter.

Actual Result:

Search page briefly goes blank when switching workspace filter.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6681072_1733041974791.ScreenRecording_12-01-2024_16-27-41_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863284324198476280
  • Upwork Job ID: 1863284324198476280
  • Last Price Increase: 2024-12-01
Issue OwnerCurrent Issue Owner: @zanyrenney
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 labels Dec 1, 2024
Copy link

melvin-bot bot commented Dec 1, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 1, 2024
@github-actions github-actions bot added Engineering and removed Daily KSv2 labels Dec 1, 2024
Copy link

melvin-bot bot commented Dec 1, 2024

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Dec 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added the Hourly KSv2 label Dec 1, 2024
Copy link

melvin-bot bot commented Dec 1, 2024

💬 A slack conversation has been started in #expensify-open-source

@mountiny mountiny added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 1, 2024
@melvin-bot melvin-bot bot changed the title iOS - Search - Search page briefly goes blank when switching workspace filter [$250] iOS - Search - Search page briefly goes blank when switching workspace filter Dec 1, 2024
Copy link

melvin-bot bot commented Dec 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021863284324198476280

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 1, 2024
Copy link

melvin-bot bot commented Dec 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@mountiny
Copy link
Contributor

mountiny commented Dec 1, 2024

@chrispader @hannojg @kirillzyusko moat likely related to the native stack change

Not blocking the user so demoted

@mountiny mountiny moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 1, 2024
Copy link

melvin-bot bot commented Dec 5, 2024

@mjasikowski, @fedirjh, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2024
@kirillzyusko
Copy link
Contributor

Hello, I'm Kiryl from Margelo expert agency and I would like to work on this issue 👋

@hannojg
Copy link
Contributor

hannojg commented Dec 11, 2024

Yes, looking into this one today!

@fedirjh
Copy link
Contributor

fedirjh commented Dec 11, 2024

Not overdue.

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2024
@hannojg
Copy link
Contributor

hannojg commented Dec 12, 2024

@chrispader will fix this issue while working on a fix for this one:

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 13, 2024
Copy link

melvin-bot bot commented Dec 24, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 26, 2024
@melvin-bot melvin-bot bot changed the title [$250] iOS - Search - Search page briefly goes blank when switching workspace filter [HOLD for payment 2025-01-02] [$250] iOS - Search - Search page briefly goes blank when switching workspace filter Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @kirillzyusko does not require payment (Contractor)
  • @fedirjh requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Dec 26, 2024

@fedirjh @zanyrenney @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@garrettmknight garrettmknight moved this from Bugs and Follow Up Issues to Hold for Payment in [#whatsnext] #expense Dec 31, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 2, 2025
Copy link

melvin-bot bot commented Jan 2, 2025

Payment Summary

Upwork Job

  • Contributor: @kirillzyusko is from an agency-contributor and not due payment
  • Reviewer: @fedirjh owed $250 via NewDot

BugZero Checklist (@zanyrenney)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1863284324198476280/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
@zanyrenney
Copy link
Contributor

I have sent a DM to @fedirjh to complete the checklist

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2025
@fedirjh
Copy link
Contributor

fedirjh commented Jan 6, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: Author aware and fixed it.

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

Test:

  1. Open the app
  2. Go to the search tab
  3. Go to the WS switcher
  4. Switch to/Filter by a workspace
  5. Make sure that there is no blank screen when navigating back to the SearchScreen.

Do we agree 👍 or 👎

@zanyrenney
Copy link
Contributor

@zanyrenney
Copy link
Contributor

Payment Summary

Contributor: @kirillzyusko is from an agency-contributor and not due payment - NO PAYMENT.
Reviewer: @fedirjh owed $250 via NewDot - PLEASE REQUEST 250USD.

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Jan 7, 2025
@garrettmknight
Copy link
Contributor

$250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

8 participants