[HOLD for payment 2025-01-07] [$250] No input autofocus when connecting Sage Intacct.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.67-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @suneox
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

1. Open the app and log in
2. Create a workspace if there is no any
3. Navigate to the workspace settings > More features and enable the Accounting option
4. Open Accounting and select Intacct
5. Upgrade the policy if it has not been done yet
6. Next to the step to enter credentials

Expected Result:

The first input field should automatically focus

Actual Result:

No input field is focused.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-11-26.at.22.25.49.mp4

Screen.Recording.2024-11-26.at.22.41.22.mp4

Recording.802.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021861840903242082245
• Upwork Job ID: 1861840903242082245
• Last Price Increase: 2024-11-27
• Automatic offers:
• CyberAndrii | Contributor | 105388358

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No input autofocus when connecting Sage Intacct.

What is the root cause of that problem?

We are not using useAutoFocusInput in this inputs

App/src/pages/workspace/accounting/intacct/EnterSageIntacctCredentialsPage.tsx

Lines 78 to 85 in afad1ac

	<InputWrapper
	InputComponent={TextInput}
	inputID={formItem}
	label={translate(`common.${formItem}`)}
	aria-label={translate(`common.${formItem}`)}
	role={CONST.ROLE.PRESENTATION}
	spellCheck={false}
	secureTextEntry={formItem === INPUT_IDS.PASSWORD}

What changes do you think we should make in order to solve the problem?

We can do the same way as we did here

    const {inputCallbackRef} = useAutoFocusInput();

    <InputWrapper
       ...
       ref={index === 0 ? inputCallbackRef : undefined}
     >

App/src/pages/workspace/accounting/intacct/EnterSageIntacctCredentialsPage.tsx

Lines 78 to 85 in afad1ac

	<InputWrapper
	InputComponent={TextInput}
	inputID={formItem}
	label={translate(`common.${formItem}`)}
	aria-label={translate(`common.${formItem}`)}
	role={CONST.ROLE.PRESENTATION}
	spellCheck={false}
	secureTextEntry={formItem === INPUT_IDS.PASSWORD}

What alternative solutions did you explore? (Optional)

NA

[suneox]

@garrettmknight I’ve reported this issue and have more context on it, so I can support with reviewing the proposal as a C+

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021861840903242082245

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@garrettmknight, @madmax330, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[CyberAndrii]

FYI, after adding useAutoFocusInput, there will be the same bug as #53314 where auto-focus stops working after closing and reopening the RHP

[thesahindia]

FYI, after adding useAutoFocusInput, there will be the same bug as #53314 where auto-focus stops working after closing and reopening the RHP

@nkdengineer, could you please verify this?

[VictoriaExpensify]

It looks like this is the same issue that is being reported for NetSuite - #53314

It seems like this is a fairly simple fix, could we combine these issues and fix it for all accounting platforms instead of handling these individually?

@madmax330 @thesahindia what do you think?

[VictoriaExpensify]

@CyberAndrii I see you've added the 😕 emoji, so let me see if I can explain this better.

The issue being worked on here is that auto-focus is not working when connecting to Sage Intacct which is an accounting integration. There is another issue raised herebecause auto-focus is not working when connecting to NetSuite, which is another accounting integration.

It sounds like these cause and fix for these issues are essentially the same i.e. once we identify the fix for one, we should be able to apply that same fix for the other. So I am suggesting that we combine these into one issue to fix autofocus when connecting to an accounting integration. It doesn't make sense to me to treat these as two entirely separate issues.

[melvin-bot]

@garrettmknight, @madmax330, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[thesahindia]

bump @nkdengineer ^

[CyberAndrii]

I guess I will post my proposal from the other issue here then

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix input autofocus on Sage Intacct/NetSuite setup pages #54396

If no regressions arise, payment will be issued on 2025-01-07. 🎊

For reference, here are some details about the assignees on this issue:

• @CyberAndrii requires payment automatic offer (Contributor)
• @thesahindia requires payment through NewDot Manual Requests
• @suneox requires payment (Needs manual offer from BZ)

[melvin-bot]

@thesahindia @garrettmknight @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[thesahindia]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: New feature (not a bug)

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Navigate to the workspaces
2. Click on a workspace > More features > enable the Accounting option
3. Go to Accounting > Select NetSuite
4. Upgrade the policy if it has not been done yet
5. Click Next until an input appears
6. Verify that the input is auto-focused
7. Dismiss the RHP by clicking outside of it or clicking on the back button
8. Repeat the same steps and verify that the input still gets autofocused
9. Select Sage Intacct and repeat the same process
10. Verify the first input gets autofocused

Do we agree 👍 or 👎

[garrettmknight]

Payment Summary:

• Contributor: @CyberAndrii $250 paid via Upwork
• Reviewer: @thesahindia $250 via NewDot

[garrettmknight]

@suneox did you review a PR on this one?

[thesahindia]

@suneox did you review a PR on this one?

They only reported the issue.

[suneox]

@suneox did you review a PR on this one?

I didn’t review the PR

[garrettmknight]

Huh, weird that you got added via the automation. Ignore the offer, please.

[garrettmknight]

@thesahindia submit for payment when you're ready!

[JmillsExpensify]

Payment summary:

• Contributor: @CyberAndrii $250 via Upwork
• Reviewer: @thesahindia $250 via NewDot

[garrettmknight]

$250 approved for @thesahindia