Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-29] Not able to submit expense to Expenses - Expensify CA workspace #52515

Closed
1 of 8 tasks
m-natarajan opened this issue Nov 14, 2024 · 13 comments
Closed
1 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Nov 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @justinpersaud
Slack conversation (hyperlinked to channel name): expensify_migrate

Action Performed:

  1. Go to Expenses - Expensify CA workspace.
  2. Click on + sign
  3. Click global create
  4. Submit expense
  5. Enter amount
  6. Select the workspace Expenses - Expensify CA workspace
  7. Submit the expense

Expected Result:

  • in step 2 "submit expense" should be available
  • Expense should be available in the workspace after created

Actual Result:

  • in step 2 "submit expense" is not available
  • Expense disappears in the workspace after created

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kadiealexander
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@kadiealexander
Copy link
Contributor

I'm not able to reproduce this (I'm not in the CA workspace and I can't repro with the AU workspace) - @aldo-expensify or @luacmartins would either of you be able to try reproduce this for us?

@luacmartins
Copy link
Contributor

Yea, I don't have the submit option from within the workspace chat.

@kadiealexander kadiealexander removed the Needs Reproduction Reproducible steps needed label Nov 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
@kadiealexander kadiealexander added Internal Requires API changes or must be handled by Expensify staff and removed Overdue labels Nov 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
@kadiealexander
Copy link
Contributor

Not overdue!

@heyjennahay
Copy link

Confirming the specifics of what is and isn't working:

  1. Via quick action button > scan receipt to Expenses - Expensify NL workspace, I get the "hmm it's not here" page ❌
  2. Via the workspace chat, there is not create expense options ❌
  3. Via global create > create expense > scan > add to workspace, does work ✅

In addition to the above, @justinpersaud cannot view his expense created under flow 3 in NewDot, only in OldDot, while mine show in both

@flaviadefaria flaviadefaria moved this to First Cohort - CRITICAL in [#whatsnext] #migrate Nov 19, 2024
@flaviadefaria flaviadefaria added the Hot Pick Ready for an engineer to pick up and run with label Nov 19, 2024
@mountiny mountiny self-assigned this Nov 19, 2024
@mountiny
Copy link
Contributor

I have done some debugging and its because the accounts payable account is the owner of the policy but its not listed in the whitelisted accounts for expensify accounts. We have this check in place so external people cannot request money from Expensify accounts I think

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 19, 2024
@mountiny
Copy link
Contributor

PR up

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 22, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Nov 22, 2024
@melvin-bot melvin-bot bot changed the title Not able to submit expense to Expenses - Expensify CA workspace [HOLD for payment 2024-11-29] Not able to submit expense to Expenses - Expensify CA workspace Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-29. 🎊

Copy link

melvin-bot bot commented Nov 22, 2024

@mountiny @kadiealexander @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@heyjennahay
Copy link

Confirming this issue has been resolved for me

@mountiny
Copy link
Contributor

mountiny commented Nov 28, 2024

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on both staging and production
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: This is a migration issue and new expensify account was not whilabelled as participant

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: This already started in Slack

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template
  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue: No need

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

@github-project-automation github-project-automation bot moved this from First Cohort - CRITICAL to Done in [#whatsnext] #migrate Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Development

No branches or pull requests

7 participants