[HOLD for payment 2024-11-29] Verify account - "Code requested" only shows in 2FA page after user opens contact method page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): wjiojdoowjojwodj@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account.
3. Go to Settings > Security > Two-factor authentication.
4. Note that there is no "Code requested. Please check your device." message.
5. Go to Profile > Contact method.
6. Click on the email.
7. Go back to Security > Two-factor authentication.
8. Now it shows "Code requested. Please check your device." message.

Expected Result:

In Step 4, 2FA page should show "Code requested. Please check your device."

Actual Result:

In Step 4, 2FA page does not show "Code requested. Please check your device."
It only shows the message (Step 8) after user opens Contact method page in Step 6.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6661745_1731353634154.20241112_031938.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 4, 2FA page does not show "Code requested. Please check your device."
It only shows the message (Step 8) after user opens Contact method page in Step 6.

What is the root cause of that problem?

We are calculating hasMagicCodeBeenSent based on login data and this is not correct when we are calling API resendValidateCode so in step 4 we don't see "Code requested. Please check your device." message

after entering contact method loginData?.validateCodeSent is updated so we go back to 2FA it will show

App/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx

Line 51 in b2d6a0e

const hasMagicCodeBeenSent = !!loginData?.validateCodeSent;

What changes do you think we should make in order to solve the problem?

We should change this line to use ONYXKEYS.VALIDATE_ACTION_CODE

    const [validateCodeAction] = useOnyx(ONYXKEYS.VALIDATE_ACTION_CODE);
    const hasMagicCodeBeenSent = !!validateCodeAction?.validateCodeSent;

What alternative solutions did you explore? (Optional)

[pecanoro]

It's coming from this PR here most likely: #51882

[hungvu193]

Don't think it's a DB but I can handle it as a regression since the contributor can't be available. I'll need to create another follow-up for that issue anyway, so lemme handle it @pecanoro

[mountiny]

@pecanoro thanks for handling, if you want to feel free to assign me to handle the regression.

[pecanoro]

@hungvu193 Ok, let's do that if the original author can't handle it!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat: Add account validation step to Invoices page #52356

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests

[melvin-bot]

@hungvu193 @adelekennedy @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot

BugZero Checklist (@adelekennedy)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[hungvu193]

We can close, this was fixed by another PR.

[melvin-bot]

@pecanoro, @hungvu193, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!