[Workspace Feeds] RemoveFeed command fails

[mountiny]

Problem

Coming from here

When removing the company card feed, the RemoveFeed command fails with 404 Bank feed does not exist

Solution

Investigate why this is happening

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

Here are some logs https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=10000&query=request_id%3A%228df583fe0b723bc4-WAW%22%20AND%20timestamp%3A%5B2024-11-08T00%3A00%20TO%202024-11-09T23%3A59%5D

[mountiny]

This is failing because the feed is pending so there is no CompanyID NVP for the feed. Gonna have to update that.

then the next thing is that the RemoveFeed command is not removing the feed from the comapnyCards settings in domain_member and it should

[mountiny]

Working on this one

[mountiny]

PR in review

[mountiny]

Merged

[mountiny]

Created one more follow up

[mountiny]

Another small PR out and deployed

[joekaufmanexpensify]

Noting that I tested here and it works well when there's only one feed. Still not 100% right when there are multiple feeds though.

LMK when this is ready to retest!

[mountiny]

@joekaufmanexpensify That is a frontend-only issue; the feed is removed, but we are not navigating/ showing another one upon deletion. It is handled here #52893

Given the backend changes for this are done, I think we can close this issue

[joekaufmanexpensify]

Sweet, sounds good. TY!