[HOLD for payment 2024-11-20] [Workspace Feeds] Transaction start date in card details page is one day prior to the selected date when assigning a card

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): quality

Action Performed:

Prerequisite:
Members and company cards added in workspace , 8+ export options for card

1. Go to staging.new.expensify.com
2. Choose the workspace from settings
3. Click company cards >Card Details

Expected Result:

Transaction start date should be same as entered when assigning the card

Actual Result:

Transaction start date in card details page is one day prior to the selected date when assigning a card

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

 

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

[m-natarajan]

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (AutoAssignerNewDotQuality)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mountiny]

Handling this as part of the project I have worked on

[waterim]

Hello, Im Artem from Callstack and would like to help with this issue!

[DylanDylann]

I would love to help on this issue with @waterim

[waterim]

I wasnt able to reproduce this issue, I thought maybe timezone was broken, but we are using strings in all parts, tested everything and works properly
@joekaufmanexpensify which timezone you are in, maybe will be able to repro with switching timezones?

But also found a bit weird unneeded date parsing with creating string from the date and after convert this string again to date and format again to string, I think this is possible that because of the timezones it can be parsed without a proper time and make this 1 day move, I will create a PR for this and you can retest, maybe this was an issue you've got!

[DylanDylann]

I also can't reproduce

[mountiny]

Joe is in new york timezone

[waterim]

@mountiny probably should work with removing new Date converting all the time, cant reproduce
@joekaufmanexpensify feel free to reproduce!

[joekaufmanexpensify]

I can still reproduce. Added here.

[DylanDylann]

@waterim This issue only can be reproduced when we set Local time is 8:30 am and EST timezone (GMT -5). The problem comes from the format function

App/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

Line 162 in b7a9c9b

title={card?.scrapeMinDate ? format(card.scrapeMinDate, CONST.DATE.FNS_FORMAT_STRING) : ''}

[DylanDylann]

I suggest updating

App/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

Line 162 in b7a9c9b

title={card?.scrapeMinDate ? format(card.scrapeMinDate, CONST.DATE.FNS_FORMAT_STRING) : ''}

title={card?.scrapeMinDate ? format(parseISO(card.scrapeMinDate), CONST.DATE.FNS_FORMAT_STRING) : ''}

[waterim]

Thank you, will try tomorrow morning, maybe format from date-fns-tz

[MitchExpensify]

@waterim Have you had a chance to come back to this?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Workspace Feed - remove unneeded extractDate from the startDate step #52150

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @MitchExpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: [NO QA]: Company card details #48491 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Set Local time is 8:30 am and EST timezone (GMT -5)

Test:

1. Open any workspace
2. Enable Company Cards
3. Click company cards
4. Assign a new card and set the custom start date as the current day
5. Go to the card detail of the created card above
6. Verify that the date displayed correctly with the date set above

Do we agree 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @waterim is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[mountiny]

Checklist done, regression test for this specific scenario is not needed I think, it will be covered with the tests for the feature we will add with Joe. Payments are handled separately for the project so closing this one for now