[$250] [HOLD for payment 2024-11-21] [Search v2.5] Allow Searching for multiple statuses

[luacmartins]

Action Performed:

1. Search for the following: status:drafts,outstanding
2. Notice that you see an infinite spinner

Expected Result:

Results should load properly

Actual Result:

Infinite spinner is shown

Workaround:

N/A

Solution

Update Auth to handle status as potentially being an array and update App accordingly. cc @lakchote if you wanna work on this as well

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857443014886824133
• Upwork Job ID: 1857443014886824133
• Last Price Increase: 2024-11-15

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[luacmartins]

@lakchote if you're interested in working on this one. The frontend already sends multiple statuses as an array, so the work that's needed here is:

• Handle multiple statuses in the backend
• Update App so we display all those results

[lakchote]

@luacmartins taking it.

[luacmartins]

Thank you! Let me know if you run into any issues

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix sort on multiple statuses #52280

If no regressions arise, payment will be issued on 2024-11-21. 🎊

[melvin-bot]

@lakchote / @luacmartins @johncschuster @lakchote / @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[johncschuster]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857443014886824133

[melvin-bot]

Current assignee @suneox is eligible for the External assigner, not assigning anyone new.

[johncschuster]

Applying External to generate the Upwork job

[johncschuster]

@suneox can you please apply to the linked job above and complete the BZ Checklist when you get a moment?

[lakchote]

Still waiting for the BZ checklist.

[suneox]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: New feature

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other: New feature

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A: this issue is a new feature

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A: Due to it isn't an impactful bug

[johncschuster]

Thank you! Payment will be issued once the regression threshold is passed 👍

[johncschuster]

Payment Summary:

Contributor+: @suneox paid $250 via Upwork - Please accept the offer!

[suneox]

Thank you! I've accept the offer

[johncschuster]

Payment has been issued! Thanks for your contributions!