[HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] Workspace - categories edited online are greyed out in settings when offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Sign in to staging.new.expensify.com
2. Navigate to a workspace > Categories
3. Edit " Travel" category
4. Disable internet
5. Navigate to settings

Expected Result:

All options are not greyed out

Actual Result:

Categories edited online appear greyed out when navigating to setting offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6651185_1730384453204.video_2024-10-31_17-20-01.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories edited online appear greyed out when navigating to setting offline

What is the root cause of that problem?

Offending PR: #51390

App/src/libs/CategoryUtils.ts

Line 79 in 3a210ad

updatedGroups[key] = group.category === oldCategoryName ? {...group, category: newCategoryName, pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE} : group;

App/src/libs/actions/Policy/Category.ts

Line 549 in 499a5bf

const updatedMccGroup = CategoryUtils.updateCategoryInMccGroup(clonedMccGroup, policyCategory.oldName, policyCategory.newName);

App/src/libs/actions/Policy/Category.ts

Line 602 in 499a5bf

mccGroup: updatedMccGroup,

We updated pendingAction for mccGroup in optimisticData but did not reset it in successData.

What changes do you think we should make in order to solve the problem?

Reset the pendingAction for mccGroup in successData in renamePolicyCategory.

[lanitochka17]

Production:

bandicam.2024-10-31.16-38-43-605.mp4

[Nodebrute]

Offending PR #51390. The failure data is also incorrect, it should be mccGroup.
https://github.com/Expensify/App/pull/51390/files#diff-fe9bfd658e57c4e63236b195c38af47ab024fc4428a9264c931adcd60c760c19R646

[youssef-lr]

@huult are you available to make a quick PR fixing the failure data?

[youssef-lr]

Going to revert as per https://expensify.slack.com/archives/C01GTK53T8Q/p1730400377188099?thread_ts=1730392335.081509&cid=C01GTK53T8Q

[huult]

@youssef-lr Please wait; I will create the pull requests within 12 hours.

[yuwenmemon]

@huult We've already deployed a revert but feel free to work on a fix with the same changes.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "fix ensure category is grayed out and name is updated when modified o…" #51829

If no regressions arise, payment will be issued on 2024-11-11. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "fix ensure category is grayed out and name is updated when modified o…" #51829

If no regressions arise, payment will be issued on 2024-11-13. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.