Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-11] [HOLD for payment 2024-11-07] Troubleshoot - Pressing CTRL + D again doesn't dismiss modal #51653

Closed
1 of 8 tasks
lanitochka17 opened this issue Oct 29, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.55-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): nathanmulugetatesting+1954@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Press CTRL + D
  3. Press CTRL + D again

Expected Result:

The troubleshoot modal gets dismissed

Actual Result:

The troubleshoot modal doesn't get dismissed instead it re appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6649178_1730198961968.bandicam_2024-10-29_13-46-56-077.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 29, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

This seems like it touched the debug modal logic #50280 @bernhardoj @parasharrajat

@parasharrajat
Copy link
Member

parasharrajat commented Oct 29, 2024

Reviewing...

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Oct 29, 2024
@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Oct 31, 2024
@Beamanator
Copy link
Contributor

Tested & fixed in staging 👍

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 31, 2024
@melvin-bot melvin-bot bot changed the title Troubleshoot - Pressing CTRL + D again doesn't dismiss modal [HOLD for payment 2024-11-07] Troubleshoot - Pressing CTRL + D again doesn't dismiss modal Oct 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

@mountiny
Copy link
Contributor

mountiny commented Nov 1, 2024

the author of the offending pr fixed this so we can close

@mountiny mountiny closed this as completed Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

@mountiny Be sure to fill out the Contact List!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 4, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-11-07] Troubleshoot - Pressing CTRL + D again doesn't dismiss modal [HOLD for payment 2024-11-11] [HOLD for payment 2024-11-07] Troubleshoot - Pressing CTRL + D again doesn't dismiss modal Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants