[Due for payment 2025-02-13] [$250] Track - Distance amount changes after submitting track distance expense with description

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh1910001@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self DM
3. Click + > Track expense > Distance
4. Enter waypoints > Next
5. On confirmation page, click Description
6. Enter a description and save it (important)
7. Take note of the distance
8. Click Track expense
9. Click Categorize it from the whisper
10. Select workspace, then category and submit it
11. Go to transaction thread

Expected Result:

The distance in the transaction thread will not change after submitting track distance expense with description

Actual Result:

The distance in the transaction thread changes to a large distance after submitting track distance expense with description
This issue only happens when the track distance expense has a description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6644153_1729759543264.20241024_163448.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849826979508811500
• Upwork Job ID: 1849826979508811500
• Last Price Increase: 2024-10-25
• Automatic offers:
• aimane-chnaif | Reviewer | 104590906
• dukenv0307 | Contributor | 104770833

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[narefyev91]

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849826979508811500

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Abrham111! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[narefyev91]

Updates from my side - identified root case place - will continue tomorrow and provide all details/PR

[melvin-bot]

@puneetlath, @narefyev91, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[narefyev91]

My research so far - after some deep logic check - i discovered that problem for sure related in success data for [getTrackExpenseInformation]
Example after commented it out:

Screen.Recording.2024-10-29.at.16.48.49.mov

Seems like issue coming closely to success data - i'm still trying to find exact code that override correct behaviour. But ended up here:

If we will remove route - we will pick correct value from route - instead of comment here:

But it's not answering a question - why does it only happened when we change description...

Will proceed tomorrow. Also potentially data may be coming wrong from API side - will check that tomorrow as well. Tested as well with offline mode - and everything was correct with optimistic data. When move back to online - data was showing incorrectly

[narefyev91]

Just re-checked what we have in Onyx for both submit with Description and without.
Compare expense report before categorised and after (with description field submitted):

Compare expense report before categorised and after (without description field submitted):

With description submit you can see that quantity is coming incorrectly. @aimane-chnaif let me know wdyt? Maybe we need a BE engineer to check what we have such difference in response

[aimane-chnaif]

Maybe we need a BE engineer to check what we have such difference in response

I think 🎀👀🎀 won't pull up any other engineer than @puneetlath (he has both roles 😄)

Edit: Sorry my guess is wrong

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rlinoz]

I believe we are incorrectly merging the rNVPs when there is a comment, I will take a better look tomorrow to check if we should send more info from the FE or fix in the BE.

https://github.com/Expensify/Auth/blob/e8549e7b4e887b1cd1e05acba254d209edf6aa5e/auth/command/AddTrackedExpenseToPolicy.cpp#L112

[rlinoz]

So I think we have to:

1. [App] Start sending the waypoints when categorizing an expense, the same way we do for track expense, since it may change when categorizing
   • I think the same applies for ShareTrackedExpense
2. [Web-E] Start passing the waypoints here in Web-E
3. [Web-E] Send the encodedCommentNVP to Auth
4. [Auth] Handle the encodedCommentNVP in Auth when updating the NVPs

[rlinoz]

I can probably write the PRs for the backend by EOW

[melvin-bot]

@puneetlath, @rlinoz, @narefyev91, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[rlinoz]

I was dragged into some other things, writing the PRs now.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix distance amount changes after submitting track distance expense with description #56146

If no regressions arise, payment will be issued on 2025-02-13. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

@dukenv0307 @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[rlinoz]

Hey @RachCHopkins 👋

@dukenv0307 is due payment in this issue for reviewing the PR

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This issue need BE and FE change, so no need to point out offending PR

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Go to staging.new.expensify.com
2. Go to self DM
3. Click + > Track expense > Distance
4. Enter waypoints > Next
5. On confirmation page, click Description
6. Enter a description and save it (important)
7. Take note of the distance
8. Click Track expense
9. Click Categorize it from the whisper
10. Select workspace, then category and submit it
11. Go to transaction thread
12. Verify that the distance in the transaction thread will not change after submitting track distance expense with description

Do we agree 👍 or 👎

[melvin-bot]

@rlinoz, @narefyev91, @RachCHopkins, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@rlinoz, @narefyev91, @RachCHopkins, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@rlinoz, @narefyev91, @RachCHopkins, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[rlinoz]

Only missing payment

cc: @RachCHopkins

[RachCHopkins]

Sorry team, not sure how I missed this! Getting onto it now!

[RachCHopkins]

@dukenv0307 that offer has long since expired, I've just sent you a new one. Let me know when it's accepted!

[RachCHopkins]

Payment Summary:

• Contributor: @narefyev91 no payment due to contractor status
• Contributor+: @dukenv0307 to be paid $250 via Upwork (new offer pending) See below

Upwork job here

[dukenv0307]

@RachCHopkins Thanks! However I'll request payment via NewDot, I was eligible for ND payment at the time I was assigned to this issue.

[RachCHopkins]

Sounds good @dukenv0307 I'll update my records!

[RachCHopkins]

Payment Summary:

• Contributor: @narefyev91 no payment due to contractor status
• Contributor+: @dukenv0307 to be paid $250 via NewDot Manual Request

Upwork job here

[RachCHopkins]

No one needs payment via Upwork, the contract has been rescinded, and the Upwork post has been closed.

[JmillsExpensify]

$250 approved for @dukenv0307