Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expo-background-fetch to execute background task #51404

Closed
szymonrybczak opened this issue Oct 24, 2024 · 7 comments
Closed

Add expo-background-fetch to execute background task #51404

szymonrybczak opened this issue Oct 24, 2024 · 7 comments
Assignees
Labels
AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App Weekly KSv2

Comments

@szymonrybczak
Copy link
Contributor

Name of library: expo-background-fetch

Details

@szymonrybczak szymonrybczak added AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App Weekly KSv2 labels Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Triggered auto assignment to @thienlnam (AutoAssignerAppLibraryReview), see https://stackoverflowteams.com/c/expensify/questions/17737 for more details.

Copy link

melvin-bot bot commented Oct 24, 2024

New Library Review

  • Are all the answers in the main description filled out properly and make sense?
  • Who maintains the library and how well is it maintained?
  • How viable are the alternatives?
  • Should we build it ourselves instead?

Once these questions are answered, start a thread in #engineering-chat, ping the @app_deployers group, and call for a vote to accept the new library. Once the vote is complete, update this issue with the outcome and procede accordingly. Here is a sample post:

Hey @app_deployers,

There is a request to add a new library to App that we need to consider. Please look at this GH and then vote :+1: or :-1: on accepting this new library or not.

GH_LINK

@szymonrybczak
Copy link
Contributor Author

For more context the library is needed to solve the problem described here.

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2024
@thienlnam
Copy link
Contributor

Thread where this convo has been happening is https://expensify.slack.com/archives/C05LX9D6E07/p1727884875529299

Seems like this is possibly being split into a few different P/S items - can you re-open if you still need this library with another P/S once that conversation is done?

@melvin-bot melvin-bot bot removed the Overdue label Nov 5, 2024
@mountiny
Copy link
Contributor

Reopening as the time has come

@mountiny mountiny reopened this Nov 12, 2024
@mountiny
Copy link
Contributor

Reshared it here

@thienlnam
Copy link
Contributor

This is going to be built instead, progress for that here: #52700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants