[$250] Set HybridApp Testflight environment to staging

[puneetlath]

Right now, when you use the HybridApp Testflight app, it is treated as a production app. This means our debugging tools are not available to use. Ideally, we should make it so that the HybridApp testflight is treated as a staging app. Just like the NewExpensify staging app is. That way we'll have access to the debug mode and various debugging tools.

cc @AndrewGable @staszekscp

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848496225680121076
• Upwork Job ID: 1848496225680121076
• Last Price Increase: 2024-10-21

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[AndrewGable]

Code in question is here: https://github.com/Expensify/App/blob/main/src/libs/Environment/getEnvironment/index.native.ts#L32-L36

[situchan]

Happy to review this as C+ since this bug I've been reviewing is related this one.

[VictoriaExpensify]

Thanks @situchan - assigned.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848496225680121076

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Set HybridApp Testflight environment to staging

What is the root cause of that problem?

Currently we return the production environment if it's hybrid app

App/src/libs/Environment/getEnvironment/index.native.ts

Lines 33 to 36 in 36805e2

	if (NativeModules.HybridAppModule) {
	environment = CONST.ENVIRONMENT.PRODUCTION;
	return;
	}

What changes do you think we should make in order to solve the problem?

We should return the staging environment CONST.ENVIRONMENT.STAGING instead of production

if (NativeModules.HybridAppModule) {
    environment = CONST.ENVIRONMENT.STAGING;
    return;
}

What alternative solutions did you explore? (Optional)

[situchan]

Asked confirmation here

[layacat]

Oh wait isn't it dupe of #50843?

[situchan]

yes dupe

[staszekscp]

Hey! 👋 I've left an update here, since this is a duplicated issue!

[puneetlath]

Ah cool, I'll close this one.