-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up: Investigate dynamic sized search string array buffer for FastSearch
#51151
Comments
Implemented here: |
@hannojg, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
@mountiny can you please reopen? The initial PR for changing the search algorithm to a search tree took longer than anticipated. We are going to look into these items next, so its still l a priority! |
Whops sorry, I confused the ticket. This one is actually done, the PR for this has been merged ! |
This is a follow up from this PR:
which was created for this issue ticket originally:
This is a follow up task.
Currently in
FastSearch
we create an array buffer which represents large string of all search values. We hard coded a length of 400k:App/src/libs/FastSearch.ts
Lines 28 to 32 in 13f41cb
This has a few drawbacks:
We want to investigate how this can be improved.
The text was updated successfully, but these errors were encountered: