Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up: Update FastSearch instance instead of recreating it on data change in SearchRouter #51150

Open
hannojg opened this issue Oct 21, 2024 · 2 comments

Comments

@hannojg
Copy link
Contributor

hannojg commented Oct 21, 2024

This is a follow up from this PR:

which was created for this issue ticket originally:

This is a follow up task. In the PR we implemented a new tree structure to enable faster searches. Right now for every data change we create a new FastSearch instance which is quite inefficient. We want to:

  • Create the FastSearch instance once, and update it on data changes
  • Right now the FastSearch instance is quite disconnected from the OptionListUtils. We should see if we can consolidate the FastSearch and OptionListUtils.
    • I think it should be possible to maybe create a search tree for the whole app, which can then be used for different use cases / all the use cases OptionListUtils is serving
@hannojg hannojg changed the title Follow up: Update FastSearch instance instead of recreating it in SearchRouter Follow up: Update FastSearch instance instead of recreating it on data change in SearchRouter Oct 21, 2024
@melvin-bot melvin-bot bot added the Monthly KSv2 label Oct 24, 2024
Copy link

melvin-bot bot commented Jan 6, 2025

@hannojg, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@hannojg
Copy link
Contributor Author

hannojg commented Jan 7, 2025

@mountiny can you please reopen? The initial PR for changing the search algorithm to a search tree took longer than anticipated. We are going to look into these items next, so it's still l a priority!

(Somehow no overdue label was ever added?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants