Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2025-02-04] Feature - Allow user to create international bank account #51082

Closed
8 tasks
MonilBhavsar opened this issue Oct 18, 2024 · 63 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Oct 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Tracking issue https://github.com/Expensify/Expensify/issues/421064
Implement this section of design doc https://docs.google.com/document/d/19ltca0iKwB00pReokjBf9rEHoi1u8y-2_x-82jMibho/edit?tab=t.0#bookmark=id.183ls0sldt64

Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Issue reported by: N/A
Slack conversation: N/A

Action Performed:

Break down in numbered steps
N/A

Expected Result:

Describe what you think should've happened
N/A

Actual Result:

Describe what actually happened
N/A

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021895154298503613105
  • Upwork Job ID: 1895154298503613105
  • Last Price Increase: 2025-02-27
@MonilBhavsar MonilBhavsar added Daily KSv2 NewFeature Something to build that is a new item. labels Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Oct 18, 2024

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@MonilBhavsar
Copy link
Contributor Author

@shawnborton sorry for the ping. This is implementation for design doc and design is already approved by the team

@shawnborton
Copy link
Contributor

No worries, just holler if you need any help!

@lschurr
Copy link
Contributor

lschurr commented Oct 18, 2024

Should we have External added here @MonilBhavsar or is this already assigned and being worked on?

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

@lschurr, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MonilBhavsar MonilBhavsar self-assigned this Oct 22, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
@shubham1206agra
Copy link
Contributor

@MonilBhavsar Can you make this weekly?

@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels Oct 22, 2024
@MonilBhavsar MonilBhavsar added Daily KSv2 and removed Weekly KSv2 labels Oct 29, 2024
@MonilBhavsar
Copy link
Contributor Author

Making this Daily again since nothing is blocking

Copy link

melvin-bot bot commented Nov 1, 2024

@MonilBhavsar, @lschurr, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 10, 2025
@lschurr
Copy link
Contributor

lschurr commented Feb 10, 2025

Bump on this @MonilBhavsar

@MonilBhavsar
Copy link
Contributor Author

Yes, I'll assign you that issue and we can pay you after that issue is closed. If that's fine for you?

@melvin-bot melvin-bot bot removed the Overdue label Feb 10, 2025
@lschurr
Copy link
Contributor

lschurr commented Feb 10, 2025

Yep, that's fine @MonilBhavsar

@lschurr
Copy link
Contributor

lschurr commented Feb 10, 2025

Closing this without payment as payment will be handled here: #55672

@joekaufmanexpensify
Copy link
Contributor

Coming from #55672 (comment), reopening this issue to handle @DylanDylann's C+ payment for this feature here, as this is the main issue for the FE implementation.

@lschurr gonna grab this one from you to handle payment.

@joekaufmanexpensify joekaufmanexpensify added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Feb 27, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-02-04] Feature - Allow user to create international bank account [$250] [HOLD for payment 2025-02-04] Feature - Allow user to create international bank account Feb 27, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021895154298503613105

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Current assignees @shubham1206agra and @DylanDylann are eligible for the External assigner, not assigning anyone new.

@joekaufmanexpensify joekaufmanexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2025
@joekaufmanexpensify
Copy link
Contributor

Summarizing the discussion here, @DylanDylann and I agreed he should be due $500 for his C+ reviews for this feature, covering:

@joekaufmanexpensify
Copy link
Contributor

Only payment due here is $500 to @DylanDylann for C+ review via upwork.

@joekaufmanexpensify joekaufmanexpensify changed the title [$250] [HOLD for payment 2025-02-04] Feature - Allow user to create international bank account [$500] [HOLD for payment 2025-02-04] Feature - Allow user to create international bank account Feb 27, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Upwork job price has been updated to $500

@joekaufmanexpensify
Copy link
Contributor

@DylanDylann offer sent for $500!

@joekaufmanexpensify
Copy link
Contributor

@DylanDylann $500 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

All set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

9 participants